Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-18 Thread Jacek Anaszewski
On 4/18/19 7:12 PM, Jacek Anaszewski wrote: On 4/18/19 2:24 PM, Takashi Iwai wrote: On Thu, 18 Apr 2019 14:21:35 +0200, Pavel Machek wrote: On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: On Wed, 17 Apr 2019 22:54:14 +0200, Jacek Anaszewski wrote: led_colors clashes with the array of the sa

Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-18 Thread Jacek Anaszewski
On 4/18/19 2:24 PM, Takashi Iwai wrote: On Thu, 18 Apr 2019 14:21:35 +0200, Pavel Machek wrote: On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: On Wed, 17 Apr 2019 22:54:14 +0200, Jacek Anaszewski wrote: led_colors clashes with the array of the same name being added to the LED class. Do the

Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-18 Thread Takashi Iwai
On Thu, 18 Apr 2019 14:21:35 +0200, Pavel Machek wrote: > > On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: > > On Wed, 17 Apr 2019 22:54:14 +0200, > > Jacek Anaszewski wrote: > > > > > > led_colors clashes with the array of the same name being added > > > to the LED class. Do the following amend

Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-18 Thread Pavel Machek
On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: > On Wed, 17 Apr 2019 22:54:14 +0200, > Jacek Anaszewski wrote: > > > > led_colors clashes with the array of the same name being added > > to the LED class. Do the following amendments to fix this issue > > and the other prospective one. > > > > led

Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-17 Thread Takashi Iwai
On Wed, 17 Apr 2019 22:54:14 +0200, Jacek Anaszewski wrote: > > led_colors clashes with the array of the same name being added > to the LED class. Do the following amendments to fix this issue > and the other prospective one. > > led_colors -> toneport_led_colors > led_init_vals -> toneport_led_i

[PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

2019-04-17 Thread Jacek Anaszewski
led_colors clashes with the array of the same name being added to the LED class. Do the following amendments to fix this issue and the other prospective one. led_colors -> toneport_led_colors led_init_vals -> toneport_led_init_vals Fixes: f44edd7b2bbed ("ALSA: line6/toneport: Implement LED contro