Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-04 Thread gre...@linuxfoundation.org
; > > jaeg...@kernel.org; Alex Lemberg ; Stanislav > > Nijnikov > > Subject: Re: [PATCH v4 02/10] ufs: sysfs: device descriptor > > > > On Fri, 2018-02-02 at 08:17 +0100, gre...@linuxfoundation.org wrote: > > > On Fri, Feb 02, 2018 at 12:25:46AM +, Bart V

RE: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-04 Thread Stanislav Nijnikov
> -Original Message- > From: Bart Van Assche > Sent: Friday, February 2, 2018 6:32 PM > To: gre...@linuxfoundation.org > Cc: linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org; > jaeg...@kernel.org; Alex Lemberg ; Stanislav > Nijnikov > Subject: Re: [PA

Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-02 Thread Bart Van Assche
On Fri, 2018-02-02 at 08:17 +0100, gre...@linuxfoundation.org wrote: > On Fri, Feb 02, 2018 at 12:25:46AM +, Bart Van Assche wrote: > > On Thu, 2018-02-01 at 18:15 +0200, Stanislav Nijnikov wrote: > > > +enum ufs_desc_param_size { > > > + UFS_PARAM_BYTE_SIZE = 1, > > > + UFS_PARAM_WORD_SIZE

Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-01 Thread gre...@linuxfoundation.org
On Fri, Feb 02, 2018 at 12:25:46AM +, Bart Van Assche wrote: > On Thu, 2018-02-01 at 18:15 +0200, Stanislav Nijnikov wrote: > > +enum ufs_desc_param_size { > > + UFS_PARAM_BYTE_SIZE = 1, > > + UFS_PARAM_WORD_SIZE = 2, > > + UFS_PARAM_DWORD_SIZE= 4, > > + UFS_PARAM_QWORD_SIZE

Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-01 Thread Bart Van Assche
On Thu, 2018-02-01 at 18:15 +0200, Stanislav Nijnikov wrote: > +ssize_t ufs_sysfs_read_desc_param(struct ufs_hba *hba, > + enum desc_idn desc_id, > + u8 desc_index, > + u8 param_offset, > +

Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-01 Thread Bart Van Assche
On Thu, 2018-02-01 at 18:15 +0200, Stanislav Nijnikov wrote: > +enum ufs_desc_param_size { > + UFS_PARAM_BYTE_SIZE = 1, > + UFS_PARAM_WORD_SIZE = 2, > + UFS_PARAM_DWORD_SIZE= 4, > + UFS_PARAM_QWORD_SIZE= 8, > +}; Please do not copy bad naming choices from the Window

Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-01 Thread Greg KH
On Thu, Feb 01, 2018 at 06:15:38PM +0200, Stanislav Nijnikov wrote: > +#define UFS_DESC_PARAM(_name, _puname, _duname, _size) > \ > +static ssize_t _name##_show(struct device *dev, > \ > + struct device_attribute *attr, char *buf)

[PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-01 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS device descriptor parameters. The group adds "device_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could be fo