Re: [PATCH v4 02/14] drm/atomic-helper: update lut props directly in ..._legacy_gamma_set

2017-07-11 Thread Peter Rosin
On 2017-07-11 10:02, Daniel Vetter wrote: > On Thu, Jul 06, 2017 at 02:20:36PM +0200, Peter Rosin wrote: >> Do not waste cycles looking up the property id when we have the >> actual property already. >> >> Signed-off-by: Peter Rosin > > With the names adjusted per my comments on

Re: [PATCH v4 02/14] drm/atomic-helper: update lut props directly in ..._legacy_gamma_set

2017-07-11 Thread Peter Rosin
On 2017-07-11 10:02, Daniel Vetter wrote: > On Thu, Jul 06, 2017 at 02:20:36PM +0200, Peter Rosin wrote: >> Do not waste cycles looking up the property id when we have the >> actual property already. >> >> Signed-off-by: Peter Rosin > > With the names adjusted per my comments on patch 1 this

Re: [PATCH v4 02/14] drm/atomic-helper: update lut props directly in ..._legacy_gamma_set

2017-07-11 Thread Daniel Vetter
On Thu, Jul 06, 2017 at 02:20:36PM +0200, Peter Rosin wrote: > Do not waste cycles looking up the property id when we have the > actual property already. > > Signed-off-by: Peter Rosin With the names adjusted per my comments on patch 1 this lgtm. Btw good practice is to cc

Re: [PATCH v4 02/14] drm/atomic-helper: update lut props directly in ..._legacy_gamma_set

2017-07-11 Thread Daniel Vetter
On Thu, Jul 06, 2017 at 02:20:36PM +0200, Peter Rosin wrote: > Do not waste cycles looking up the property id when we have the > actual property already. > > Signed-off-by: Peter Rosin With the names adjusted per my comments on patch 1 this lgtm. Btw good practice is to cc original authors of

[PATCH v4 02/14] drm/atomic-helper: update lut props directly in ..._legacy_gamma_set

2017-07-06 Thread Peter Rosin
Do not waste cycles looking up the property id when we have the actual property already. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_atomic_helper.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git

[PATCH v4 02/14] drm/atomic-helper: update lut props directly in ..._legacy_gamma_set

2017-07-06 Thread Peter Rosin
Do not waste cycles looking up the property id when we have the actual property already. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_atomic_helper.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c