Re: [PATCH v4 02/22] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-28 Thread Maxime Ripard
On Mon, Sep 21, 2020 at 07:15:13PM +0200, Clément Péron wrote: > Hi Maxime, > > On Mon, 21 Sep 2020 at 14:29, Maxime Ripard wrote: > > > > On Mon, Sep 21, 2020 at 12:27:11PM +0200, Clément Péron wrote: > > > As slots and slot_width can be overwritter in case set_tdm() is > > > called. Avoid to ha

Re: [PATCH v4 02/22] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-21 Thread Mark Brown
On Mon, Sep 21, 2020 at 07:15:13PM +0200, Clément Péron wrote: > On Mon, 21 Sep 2020 at 14:29, Maxime Ripard wrote: > > Also, Fixes tag? > I think this only happens when 20/24bit is enabled so the issue has been > introduced in this series. For a situation like that a note in the changelog abou

Re: [PATCH v4 02/22] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-21 Thread Clément Péron
Hi Maxime, On Mon, 21 Sep 2020 at 14:29, Maxime Ripard wrote: > > On Mon, Sep 21, 2020 at 12:27:11PM +0200, Clément Péron wrote: > > As slots and slot_width can be overwritter in case set_tdm() is > > called. Avoid to have this logic in set_chan_cfg(). > > > > Instead pass the required values as

Re: [PATCH v4 02/22] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-21 Thread Maxime Ripard
On Mon, Sep 21, 2020 at 12:27:11PM +0200, Clément Péron wrote: > As slots and slot_width can be overwritter in case set_tdm() is > called. Avoid to have this logic in set_chan_cfg(). > > Instead pass the required values as params to set_chan_cfg(). It's not really clear here what the issue is, an

[PATCH v4 02/22] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-21 Thread Clément Péron
As slots and slot_width can be overwritter in case set_tdm() is called. Avoid to have this logic in set_chan_cfg(). Instead pass the required values as params to set_chan_cfg(). This also fix a bug when i2s->slot_width is set for TDM but not properly used in set_chan_cfg(). Suggested-by: Samuel