RE: [PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:27:33, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:01PM +0530, Philip, Avinash wrote: > [...] > > +static const struct of_device_id ecap_of_match[] = { > > + { > > + .compatible = "ti,am33xx-ecap", > > + }, > > Same here, can be shorter by put

Re: [PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-22 Thread Thierry Reding
I forgot, the subject should be: pwm: tiecap: Add device-tree binding for consistency. Same applies for patches 5, 6, 7 and 8. Thierry pgpIuLv1Q00IP.pgp Description: PGP signature

Re: [PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-22 Thread Thierry Reding
On Wed, Nov 21, 2012 at 06:41:01PM +0530, Philip, Avinash wrote: [...] > +static const struct of_device_id ecap_of_match[] = { > + { > + .compatible = "ti,am33xx-ecap", > + }, Same here, can be shorter by putting it on one line instead of three. Thierry pgpwmc0a5pt0K.pgp

[PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-21 Thread Philip, Avinash
This patch 1. Add support for device-tree binding for ECAP APWM driver. 2. Set size of pwm-cells set to 3 to support PWM channel number, PWM period & polarity configuration from device tree. 3. Add enable/disable clock gating in PWM subsystem common config space. 4. When here set .owner member i