Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Guenter Roeck
On 6/5/20 9:04 AM, Andy Shevchenko wrote: > On Fri, Jun 5, 2020 at 6:05 PM Guenter Roeck wrote: >> On Fri, Jun 05, 2020 at 05:09:11PM +0300, Andy Shevchenko wrote: >>> On Fri, Jun 05, 2020 at 06:52:00AM -0700, Guenter Roeck wrote: On 6/5/20 3:50 AM, Andy Shevchenko wrote: > On Fri, Jun 5,

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 6:05 PM Guenter Roeck wrote: > On Fri, Jun 05, 2020 at 05:09:11PM +0300, Andy Shevchenko wrote: > > On Fri, Jun 05, 2020 at 06:52:00AM -0700, Guenter Roeck wrote: > > > On 6/5/20 3:50 AM, Andy Shevchenko wrote: > > > > On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: > >

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Guenter Roeck
On Fri, Jun 05, 2020 at 05:09:11PM +0300, Andy Shevchenko wrote: > On Fri, Jun 05, 2020 at 06:52:00AM -0700, Guenter Roeck wrote: > > On 6/5/20 3:50 AM, Andy Shevchenko wrote: > > > On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: > > >> Am 2020-06-05 10:14, schrieb Andy Shevchenko: > > >>> On

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 05, 2020 at 06:52:00AM -0700, Guenter Roeck wrote: > On 6/5/20 3:50 AM, Andy Shevchenko wrote: > > On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: > >> Am 2020-06-05 10:14, schrieb Andy Shevchenko: > >>> On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: ... > +static boo

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Guenter Roeck
On 6/5/20 3:50 AM, Andy Shevchenko wrote: > On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: >> Am 2020-06-05 10:14, schrieb Andy Shevchenko: >>> On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: > > ... > +static bool nowayout = WATCHDOG_NOWAYOUT; +module_param(nowayout, bool,

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: > Am 2020-06-05 10:14, schrieb Andy Shevchenko: > > On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: ... > >> +static bool nowayout = WATCHDOG_NOWAYOUT; > >> +module_param(nowayout, bool, 0); > >> +MODULE_PARM_DESC(nowayout, "Watchdog cann

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Michael Walle
Am 2020-06-05 10:14, schrieb Andy Shevchenko: On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: Add support for the watchdog of the sl28cpld board management controller. This is part of a multi-function device driver. ... +#include Didn't find a user of this. I guess mod_devicetabl

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: > > Add support for the watchdog of the sl28cpld board management > controller. This is part of a multi-function device driver. ... > +#include Didn't find a user of this. ... > +static bool nowayout = WATCHDOG_NOWAYOUT; > +module_param(no

[PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-04 Thread Michael Walle
Add support for the watchdog of the sl28cpld board management controller. This is part of a multi-function device driver. Signed-off-by: Michael Walle Acked-by: Guenter Roeck --- drivers/watchdog/Kconfig| 11 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/sl28cpld_wdt.c |