Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-13 Thread Luis R. Rodriguez
On Thu, Apr 7, 2016 at 2:42 AM, David Vrabel wrote: > On 07/04/16 01:06, Luis R. Rodriguez wrote: >> We have 4 types of x86 platforms that disable RTC: >> >> * Intel MID >> * Lguest - uses paravirt >> * Xen dom-U - uses paravirt >> * x86 on legacy systems

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-13 Thread Luis R. Rodriguez
On Thu, Apr 7, 2016 at 2:42 AM, David Vrabel wrote: > On 07/04/16 01:06, Luis R. Rodriguez wrote: >> We have 4 types of x86 platforms that disable RTC: >> >> * Intel MID >> * Lguest - uses paravirt >> * Xen dom-U - uses paravirt >> * x86 on legacy systems annotated with an ACPI legacy

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Fri, Apr 08, 2016 at 08:37:44AM -0400, Boris Ostrovsky wrote: > On 04/08/2016 03:59 AM, Juergen Gross wrote: > >On 08/04/16 09:36, Luis R. Rodriguez wrote: > >>On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: > >>>On 08/04/16 08:56, Luis R. Rodriguez wrote: > On Thu,

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Fri, Apr 08, 2016 at 08:37:44AM -0400, Boris Ostrovsky wrote: > On 04/08/2016 03:59 AM, Juergen Gross wrote: > >On 08/04/16 09:36, Luis R. Rodriguez wrote: > >>On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: > >>>On 08/04/16 08:56, Luis R. Rodriguez wrote: > On Thu, Apr 7, 2016 at

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Boris Ostrovsky
On 04/08/2016 03:59 AM, Juergen Gross wrote: On 08/04/16 09:36, Luis R. Rodriguez wrote: On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: On 08/04/16 08:56, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: Okay. Another

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Boris Ostrovsky
On 04/08/2016 03:59 AM, Juergen Gross wrote: On 08/04/16 09:36, Luis R. Rodriguez wrote: On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: On 08/04/16 08:56, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: Okay. Another idea (not sure whether this is

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Boris Ostrovsky
On 04/08/2016 02:29 AM, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: On 08/04/16 02:32, Luis R. Rodriguez wrote: On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: We have 4

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Boris Ostrovsky
On 04/08/2016 02:29 AM, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: On 08/04/16 02:32, Luis R. Rodriguez wrote: On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: We have 4 types of x86

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Juergen Gross
On 08/04/16 09:36, Luis R. Rodriguez wrote: > On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: >> On 08/04/16 08:56, Luis R. Rodriguez wrote: >>> On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: On 08/04/16 08:29, Luis R. Rodriguez wrote: > On

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Juergen Gross
On 08/04/16 09:36, Luis R. Rodriguez wrote: > On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: >> On 08/04/16 08:56, Luis R. Rodriguez wrote: >>> On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: On 08/04/16 08:29, Luis R. Rodriguez wrote: > On Thu, Apr 7, 2016 at 10:18 PM,

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: > On 08/04/16 08:56, Luis R. Rodriguez wrote: >> On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: >>> On 08/04/16 08:29, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: > On 08/04/16 08:56, Luis R. Rodriguez wrote: >> On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: >>> On 08/04/16 08:29, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: > On 08/04/16 02:32, Luis

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Juergen Gross
On 08/04/16 08:56, Luis R. Rodriguez wrote: > On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: >> On 08/04/16 08:29, Luis R. Rodriguez wrote: >>> On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: On 08/04/16 02:32, Luis R. Rodriguez wrote: >

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Juergen Gross
On 08/04/16 08:56, Luis R. Rodriguez wrote: > On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: >> On 08/04/16 08:29, Luis R. Rodriguez wrote: >>> On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: On 08/04/16 02:32, Luis R. Rodriguez wrote: > This highlights a semantic gap

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: > On 08/04/16 08:29, Luis R. Rodriguez wrote: >> On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: >>> On 08/04/16 02:32, Luis R. Rodriguez wrote: This highlights a semantic gap issue. From a quick

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: > On 08/04/16 08:29, Luis R. Rodriguez wrote: >> On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: >>> On 08/04/16 02:32, Luis R. Rodriguez wrote: This highlights a semantic gap issue. From a quick cursory review, I think we can

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Juergen Gross
On 08/04/16 08:29, Luis R. Rodriguez wrote: > On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: >> On 08/04/16 02:32, Luis R. Rodriguez wrote: >>> This highlights a semantic gap issue. From a quick cursory review, I think >>> we can address this temporarily by just using a

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Juergen Gross
On 08/04/16 08:29, Luis R. Rodriguez wrote: > On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: >> On 08/04/16 02:32, Luis R. Rodriguez wrote: >>> This highlights a semantic gap issue. From a quick cursory review, I think >>> we can address this temporarily by just using a check: >>> >>> void

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: > On 08/04/16 02:32, Luis R. Rodriguez wrote: >> On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: >>> On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: We have 4 types of x86 platforms that disable RTC:

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: > On 08/04/16 02:32, Luis R. Rodriguez wrote: >> On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: >>> On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: We have 4 types of x86 platforms that disable RTC: * Intel

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread Juergen Gross
On 08/04/16 02:32, Luis R. Rodriguez wrote: > On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: >> On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: >>> We have 4 types of x86 platforms that disable RTC: >>> >>> * Intel MID >>> * Lguest - uses paravirt >>> * Xen dom-U - uses

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread Juergen Gross
On 08/04/16 02:32, Luis R. Rodriguez wrote: > On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: >> On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: >>> We have 4 types of x86 platforms that disable RTC: >>> >>> * Intel MID >>> * Lguest - uses paravirt >>> * Xen dom-U - uses

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread Luis R. Rodriguez
On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: > On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: > >We have 4 types of x86 platforms that disable RTC: > > > > * Intel MID > > * Lguest - uses paravirt > > * Xen dom-U - uses paravirt > > * x86 on legacy systems annotated

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread Luis R. Rodriguez
On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: > On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: > >We have 4 types of x86 platforms that disable RTC: > > > > * Intel MID > > * Lguest - uses paravirt > > * Xen dom-U - uses paravirt > > * x86 on legacy systems annotated

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread Boris Ostrovsky
On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: We have 4 types of x86 platforms that disable RTC: * Intel MID * Lguest - uses paravirt * Xen dom-U - uses paravirt * x86 on legacy systems annotated with an ACPI legacy flag We can consolidate all of these into a platform specific

Re: [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread Boris Ostrovsky
On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: We have 4 types of x86 platforms that disable RTC: * Intel MID * Lguest - uses paravirt * Xen dom-U - uses paravirt * x86 on legacy systems annotated with an ACPI legacy flag We can consolidate all of these into a platform specific

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread David Vrabel
On 07/04/16 01:06, Luis R. Rodriguez wrote: > We have 4 types of x86 platforms that disable RTC: > > * Intel MID > * Lguest - uses paravirt > * Xen dom-U - uses paravirt > * x86 on legacy systems annotated with an ACPI legacy flag > > We can consolidate all of these into a platform

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread David Vrabel
On 07/04/16 01:06, Luis R. Rodriguez wrote: > We have 4 types of x86 platforms that disable RTC: > > * Intel MID > * Lguest - uses paravirt > * Xen dom-U - uses paravirt > * x86 on legacy systems annotated with an ACPI legacy flag > > We can consolidate all of these into a platform

[PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-06 Thread Luis R. Rodriguez
We have 4 types of x86 platforms that disable RTC: * Intel MID * Lguest - uses paravirt * Xen dom-U - uses paravirt * x86 on legacy systems annotated with an ACPI legacy flag We can consolidate all of these into a platform specific legacy quirk set early in boot through

[PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-06 Thread Luis R. Rodriguez
We have 4 types of x86 platforms that disable RTC: * Intel MID * Lguest - uses paravirt * Xen dom-U - uses paravirt * x86 on legacy systems annotated with an ACPI legacy flag We can consolidate all of these into a platform specific legacy quirk set early in boot through