Re: [PATCH v4 04/29] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated

2016-06-28 Thread Andy Lutomirski
On Tue, Jun 28, 2016 at 11:48 AM, Borislav Petkov wrote: > On Sun, Jun 26, 2016 at 02:55:26PM -0700, Andy Lutomirski wrote: >> This avoids pointless races in which another CPU or task might see a >> partially populated global pgd entry. These races should normally >> be harmless, but, if another

Re: [PATCH v4 04/29] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated

2016-06-28 Thread Borislav Petkov
On Sun, Jun 26, 2016 at 02:55:26PM -0700, Andy Lutomirski wrote: > This avoids pointless races in which another CPU or task might see a > partially populated global pgd entry. These races should normally > be harmless, but, if another CPU propagates the entry via > vmalloc_fault and then populate_

[PATCH v4 04/29] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated

2016-06-26 Thread Andy Lutomirski
This avoids pointless races in which another CPU or task might see a partially populated global pgd entry. These races should normally be harmless, but, if another CPU propagates the entry via vmalloc_fault and then populate_pgd fails (due to memory allocation failure, for example), this prevents