Re: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports

2014-11-27 Thread Michael S. Tsirkin
On Thu, Nov 27, 2014 at 12:02:52PM +0100, Cornelia Huck wrote: > On Thu, 27 Nov 2014 12:54:34 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Nov 26, 2014 at 10:09:54AM +0100, Cornelia Huck wrote: > > > > The old s390 virtio transport in kvm_virtio.c is not part of virtio 1.0. > > > > It migh

Re: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports

2014-11-27 Thread Cornelia Huck
On Thu, 27 Nov 2014 12:54:34 +0200 "Michael S. Tsirkin" wrote: > On Wed, Nov 26, 2014 at 10:09:54AM +0100, Cornelia Huck wrote: > > The old s390 virtio transport in kvm_virtio.c is not part of virtio 1.0. > > It might or might not be a good idea to add code in kvm_virtio.c > blacklisting VIRTIO

Re: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports

2014-11-27 Thread Michael S. Tsirkin
On Wed, Nov 26, 2014 at 10:09:54AM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 23:20:11 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Nov 25, 2014 at 06:29:42PM +0100, Cornelia Huck wrote: > > > On Tue, 25 Nov 2014 18:41:35 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > disable

Re: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports

2014-11-26 Thread Cornelia Huck
On Tue, 25 Nov 2014 23:20:11 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 25, 2014 at 06:29:42PM +0100, Cornelia Huck wrote: > > On Tue, 25 Nov 2014 18:41:35 +0200 > > "Michael S. Tsirkin" wrote: > > > > > disable virtio 1.0 in transports that don't > > > support it yet. > > > > I'd prefer

Re: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports

2014-11-25 Thread Michael S. Tsirkin
On Tue, Nov 25, 2014 at 06:29:42PM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 18:41:35 +0200 > "Michael S. Tsirkin" wrote: > > > disable virtio 1.0 in transports that don't > > support it yet. > > I'd prefer if you disabled it for _every_ transport in this patch, > until the needed infras

Re: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports

2014-11-25 Thread Cornelia Huck
On Tue, 25 Nov 2014 18:41:35 +0200 "Michael S. Tsirkin" wrote: > disable virtio 1.0 in transports that don't > support it yet. I'd prefer if you disabled it for _every_ transport in this patch, until the needed infrastructure is in place. Else this is a bit confusing. > We will gradually re-ena

[PATCH v4 04/42] virtio: disable virtio 1.0 in transports

2014-11-25 Thread Michael S. Tsirkin
disable virtio 1.0 in transports that don't support it yet. We will gradually re-enable as support is added. Signed-off-by: Michael S. Tsirkin --- drivers/lguest/lguest_device.c | 3 ++- drivers/misc/mic/card/mic_virtio.c | 2 ++ drivers/s390/kvm/virtio_ccw.c | 3 ++- drivers/virtio/vir