Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-27 Thread Peter Korsgaard
> "Thierry" == Thierry Reding writes: Hi, >> There's several different situations: >> >> - Platform without pinctrl support >> - Platform with pinctrl support but no pinmux specified in dt for device >> (E.G. pinmux setup in bootloader) >> - Pinmux specified in dt >> - Some kind of m

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-24 Thread Thierry Reding
On Fri, Nov 23, 2012 at 01:48:51PM +0100, Peter Korsgaard wrote: > > "Thierry" == Thierry Reding writes: > > Hi, > > Thierry> Everybody seems to be doing it with a warning, so I guess > Thierry> that's fine for now. I just find it strange that if you > Thierry> request the default pin gro

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Peter Korsgaard
> "Thierry" == Thierry Reding writes: Hi, Thierry> Everybody seems to be doing it with a warning, so I guess Thierry> that's fine for now. I just find it strange that if you Thierry> request the default pin group to be selected when in fact the Thierry> hardware doesn't support pinctrl a

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Thierry Reding
On Fri, Nov 23, 2012 at 11:12:15AM +, Philip, Avinash wrote: > On Fri, Nov 23, 2012 at 16:21:10, Thierry Reding wrote: > > On Fri, Nov 23, 2012 at 10:34:02AM +, Philip, Avinash wrote: > > > On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > > > > On Wed, Nov 21, 2012 at 06:41:02PM +0

RE: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 16:21:10, Thierry Reding wrote: > On Fri, Nov 23, 2012 at 10:34:02AM +, Philip, Avinash wrote: > > On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > > > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > > > [...] > > > > + pinctrl = devm_pi

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Thierry Reding
On Fri, Nov 23, 2012 at 10:34:02AM +, Philip, Avinash wrote: > On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > > [...] > > > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > > > + if (IS_ERR(pinctrl)) > > >

RE: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > [...] > > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > > + if (IS_ERR(pinctrl)) > > + dev_warn(&pdev->dev, "failed to configure pins from driver\n

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-22 Thread Thierry Reding
On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > Enable pinctrl for pwm-tiecap This could probably be more verbose. Maybe explain some more what exactly this means. Thierry pgplbSkAZxUES.pgp Description: PGP signature

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-22 Thread Thierry Reding
On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: [...] > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > + if (IS_ERR(pinctrl)) > + dev_warn(&pdev->dev, "failed to configure pins from driver\n"); I think we already discussed this, but shouldn't this b

[PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-21 Thread Philip, Avinash
Enable pinctrl for pwm-tiecap Signed-off-by: Philip, Avinash --- :100644 100644 e0bcc85... 646f8b4... M drivers/pwm/pwm-tiecap.c drivers/pwm/pwm-tiecap.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c index e0bcc