Re: [PATCH v4 05/15] perf tools report: Parse time quantum

2019-03-08 Thread Andi Kleen
On Fri, Mar 08, 2019 at 10:52:36AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Mar 08, 2019 at 10:45:32AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Mar 05, 2019 at 06:47:48AM -0800, Andi Kleen escreveu: > > > From: Andi Kleen > > > + if (*end == 0) > > > + return 0; > >

Re: [PATCH v4 05/15] perf tools report: Parse time quantum

2019-03-08 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 08, 2019 at 10:45:32AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Mar 05, 2019 at 06:47:48AM -0800, Andi Kleen escreveu: > > From: Andi Kleen > > + if (*end == 0) > > + return 0; > > We have tools/include/linux/time64.h, just like the kernel, so please > use: >

Re: [PATCH v4 05/15] perf tools report: Parse time quantum

2019-03-08 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 05, 2019 at 06:47:48AM -0800, Andi Kleen escreveu: > From: Andi Kleen > > Many workloads change over time. perf report currently aggregates > the whole time range reported in perf.data. > > This patch adds an option for a time quantum to quantisize the > perf.data over time. > >

[PATCH v4 05/15] perf tools report: Parse time quantum

2019-03-05 Thread Andi Kleen
From: Andi Kleen Many workloads change over time. perf report currently aggregates the whole time range reported in perf.data. This patch adds an option for a time quantum to quantisize the perf.data over time. This just adds the option, will be used in follow on patches for a time sort key.