Re: [PATCH v4 05/16] block: sed-opal: unify cmd start

2019-02-08 Thread Derrick, Jonathan
Looks fine with 4/16 Acked-by: Jon Derrick On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote: > Every step starts with resetting the cmd buffer as well as the comid and > constructs the appropriate OPAL_CALL command. Consequently, those > actions may be combined into one generic function. On

Re: [PATCH v4 05/16] block: sed-opal: unify cmd start

2019-02-04 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[PATCH v4 05/16] block: sed-opal: unify cmd start

2019-02-01 Thread David Kozub
Every step starts with resetting the cmd buffer as well as the comid and constructs the appropriate OPAL_CALL command. Consequently, those actions may be combined into one generic function. On should take care that the opening and closing tokens for the argument list are already emitted by cmd_star