Re: [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-12 Thread Vivek Gautam
On Fri, Jan 12, 2018 at 2:16 PM, Manu Gautam wrote: > Hi Vivek, > > > On 1/12/2018 2:14 PM, Vivek Gautam wrote: >> On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: >>> PHY block or asynchronous reset requires signal >>> to be asserted before

Re: [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-12 Thread Vivek Gautam
On Fri, Jan 12, 2018 at 2:16 PM, Manu Gautam wrote: > Hi Vivek, > > > On 1/12/2018 2:14 PM, Vivek Gautam wrote: >> On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: >>> PHY block or asynchronous reset requires signal >>> to be asserted before de-asserting. Driver is only >>> de-asserting signal

Re: [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-12 Thread Manu Gautam
Hi Vivek, On 1/12/2018 2:14 PM, Vivek Gautam wrote: > On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: >> PHY block or asynchronous reset requires signal >> to be asserted before de-asserting. Driver is only >> de-asserting signal which is already low, hence >> reset

Re: [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-12 Thread Manu Gautam
Hi Vivek, On 1/12/2018 2:14 PM, Vivek Gautam wrote: > On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: >> PHY block or asynchronous reset requires signal >> to be asserted before de-asserting. Driver is only >> de-asserting signal which is already low, hence >> reset operation is a no-op. Fix

Re: [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-12 Thread Vivek Gautam
On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: > PHY block or asynchronous reset requires signal > to be asserted before de-asserting. Driver is only > de-asserting signal which is already low, hence > reset operation is a no-op. Fix this by asserting > signal first.

Re: [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-12 Thread Vivek Gautam
On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: > PHY block or asynchronous reset requires signal > to be asserted before de-asserting. Driver is only > de-asserting signal which is already low, hence > reset operation is a no-op. Fix this by asserting > signal first. Also, resetting requires

[PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-03 Thread Manu Gautam
PHY block or asynchronous reset requires signal to be asserted before de-asserting. Driver is only de-asserting signal which is already low, hence reset operation is a no-op. Fix this by asserting signal first. Also, resetting requires PHY clocks to be turned ON only after reset is finished. Fix

[PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-03 Thread Manu Gautam
PHY block or asynchronous reset requires signal to be asserted before de-asserting. Driver is only de-asserting signal which is already low, hence reset operation is a no-op. Fix this by asserting signal first. Also, resetting requires PHY clocks to be turned ON only after reset is finished. Fix