Re: [PATCH v4 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT

2013-01-07 Thread Stephane Eranian
Andi, I also think we should drop PERF_FORMAT_WEIGHT. You added it in your patch but there is no code to actually perform the read. Will remove it from your patch in my series. We can always add it later on. On Mon, Jan 7, 2013 at 2:27 PM, Jiri Olsa wrote: > On Mon, Jan 07, 2013 at 02:10:20PM +

Re: [PATCH v4 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT

2013-01-07 Thread Jiri Olsa
On Mon, Jan 07, 2013 at 02:10:20PM +0100, Stephane Eranian wrote: > On Wed, Jan 2, 2013 at 3:07 PM, Jiri Olsa wrote: > > On Thu, Dec 20, 2012 at 04:41:35PM +0100, Stephane Eranian wrote: > >> Ensure we grab the weight from raw sample struct > >> and that we can dump it via perf report -D. > >> >

Re: [PATCH v4 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT

2013-01-07 Thread Stephane Eranian
On Wed, Jan 2, 2013 at 3:07 PM, Jiri Olsa wrote: > On Thu, Dec 20, 2012 at 04:41:35PM +0100, Stephane Eranian wrote: >> Ensure we grab the weight from raw sample struct >> and that we can dump it via perf report -D. >> >> Signed-off-by: Stephane Eranian >> --- >> tools/perf/util/event.h |

Re: [PATCH v4 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT

2013-01-02 Thread Jiri Olsa
On Thu, Dec 20, 2012 at 04:41:35PM +0100, Stephane Eranian wrote: > Ensure we grab the weight from raw sample struct > and that we can dump it via perf report -D. > > Signed-off-by: Stephane Eranian > --- > tools/perf/util/event.h |1 + > tools/perf/util/evsel.c |5 + > tools/pe

[PATCH v4 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT

2012-12-20 Thread Stephane Eranian
Ensure we grab the weight from raw sample struct and that we can dump it via perf report -D. Signed-off-by: Stephane Eranian --- tools/perf/util/event.h |1 + tools/perf/util/evsel.c |5 + tools/perf/util/session.c |3 +++ 3 files changed, 9 insertions(+) diff --git a/tools