Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()

2018-05-20 Thread Masahiro Yamada
2018-05-20 23:39 GMT+09:00 Sam Ravnborg : >> @@ -544,10 +530,10 @@ void conf_parse(const char *name) >> if (!modules_sym) >> modules_sym = sym_find( "n" ); >> >> - tmp = rootmenu.prompt->text; >> - rootmenu.prompt->text = _(rootmenu.prompt->text); >> - rootmenu.prom

Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()

2018-05-20 Thread Sam Ravnborg
On Thu, May 17, 2018 at 03:16:44PM +0900, Masahiro Yamada wrote: > Now that environments are expanded in the lexer, conf_parse() does > not need to expand them explicitly. > > The hack introduced by commit 0724a7c32a54 ("kconfig: Don't leak > main menus during parsing") can go away. > > Signed-of

[PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()

2018-05-16 Thread Masahiro Yamada
Now that environments are expanded in the lexer, conf_parse() does not need to expand them explicitly. The hack introduced by commit 0724a7c32a54 ("kconfig: Don't leak main menus during parsing") can go away. Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook Reviewed-by: Ulf Magnusson ---