Re: [PATCH v4 07/10] regulator: mt6358: Add support for MT6358 regulator

2019-08-06 Thread Hsin-hsiung Wang
Hi Mark, On Mon, 2019-08-05 at 14:10 +0100, Mark Brown wrote: > On Mon, Aug 05, 2019 at 01:21:55PM +0800, Hsin-Hsiung Wang wrote: > > > +static const u32 vmch_voltages[] = { > > + 290, 300, 330, > > +}; > > > +static const u32 vemc_voltages[] = { > > + 290, 300, 330,

Re: [PATCH v4 07/10] regulator: mt6358: Add support for MT6358 regulator

2019-08-05 Thread Mark Brown
On Mon, Aug 05, 2019 at 01:21:55PM +0800, Hsin-Hsiung Wang wrote: > +static const u32 vmch_voltages[] = { > + 290, 300, 330, > +}; > +static const u32 vemc_voltages[] = { > + 290, 300, 330, > +}; Several of these tables appear to be identical. > +static inline

[PATCH v4 07/10] regulator: mt6358: Add support for MT6358 regulator

2019-08-04 Thread Hsin-Hsiung Wang
The MT6358 is a regulator found on boards based on MediaTek MT8183 and probably other SoCs. It is a so called pmic and connects as a slave to SoC using SPI, wrapped inside the pmic-wrapper. Signed-off-by: Hsin-Hsiung Wang --- drivers/regulator/Kconfig | 9 +