Re: [PATCH v4 07/18] perf: add generic memory sampling interface

2013-01-05 Thread Andi Kleen
> Why dont use enums for this? enums can have unpredictable signed/unsignedness issues. #defines for hardware constants is usually far safer. -Andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [PATCH v4 07/18] perf: add generic memory sampling interface

2013-01-05 Thread Jiri Olsa
On Thu, Dec 20, 2012 at 04:41:37PM +0100, Stephane Eranian wrote: > This patch adds PERF_SAMPLE_COST and PERF_SAMPLE_DSRC. > The first collects a cost associated with the sampled > event. In case of memory access, the cost would be > the latency of the load, otherwise it defaults to > the sampling

Re: [PATCH v4 07/18] perf: add generic memory sampling interface

2013-01-05 Thread Jiri Olsa
On Thu, Dec 20, 2012 at 04:41:37PM +0100, Stephane Eranian wrote: > This patch adds PERF_SAMPLE_COST and PERF_SAMPLE_DSRC. I guess PERF_SAMPLE_COST was replaced by PERF_SAMPLE_WEIGHT added by Andi jirka > The first collects a cost associated with the sampled > event. In case of memory access, th

[PATCH v4 07/18] perf: add generic memory sampling interface

2012-12-20 Thread Stephane Eranian
This patch adds PERF_SAMPLE_COST and PERF_SAMPLE_DSRC. The first collects a cost associated with the sampled event. In case of memory access, the cost would be the latency of the load, otherwise it defaults to the sampling period. PERF_SAMPLE_DSRC collects the data source, i.e., where did the data