Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Alex Elder
On 05/25/2015 10:02 AM, Ilya Dryomov wrote: > On Mon, May 25, 2015 at 5:04 PM, Christoph Hellwig wrote: >> On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote: >>> From: Kent Overstreet >>> >>> As generic_make_request() is now able to handle arbitrarily sized bios, >>> it's no longer

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Ilya Dryomov
On Mon, May 25, 2015 at 6:08 PM, Christoph Hellwig wrote: > On Mon, May 25, 2015 at 06:02:30PM +0300, Ilya Dryomov wrote: >> I'm not Alex, but yeah, we have all the clone/split machinery and so we >> can handle a spanning case just fine. I think rbd_merge_bvec() exists >> to make sure we don't

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Christoph Hellwig
On Mon, May 25, 2015 at 06:02:30PM +0300, Ilya Dryomov wrote: > I'm not Alex, but yeah, we have all the clone/split machinery and so we > can handle a spanning case just fine. I think rbd_merge_bvec() exists > to make sure we don't have to do that unless it's really necessary - > like when a

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Ilya Dryomov
On Mon, May 25, 2015 at 5:04 PM, Christoph Hellwig wrote: > On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote: >> From: Kent Overstreet >> >> As generic_make_request() is now able to handle arbitrarily sized bios, >> it's no longer necessary for each individual block driver to define its

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Christoph Hellwig
On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote: > From: Kent Overstreet > > As generic_make_request() is now able to handle arbitrarily sized bios, > it's no longer necessary for each individual block driver to define its > own ->merge_bvec_fn() callback. Remove every invocation

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Christoph Hellwig
On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote: From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own -merge_bvec_fn() callback. Remove

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Christoph Hellwig
On Mon, May 25, 2015 at 06:02:30PM +0300, Ilya Dryomov wrote: I'm not Alex, but yeah, we have all the clone/split machinery and so we can handle a spanning case just fine. I think rbd_merge_bvec() exists to make sure we don't have to do that unless it's really necessary - like when a single

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Alex Elder
On 05/25/2015 10:02 AM, Ilya Dryomov wrote: On Mon, May 25, 2015 at 5:04 PM, Christoph Hellwig h...@lst.de wrote: On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote: From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios,

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Ilya Dryomov
On Mon, May 25, 2015 at 6:08 PM, Christoph Hellwig h...@lst.de wrote: On Mon, May 25, 2015 at 06:02:30PM +0300, Ilya Dryomov wrote: I'm not Alex, but yeah, we have all the clone/split machinery and so we can handle a spanning case just fine. I think rbd_merge_bvec() exists to make sure we

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-25 Thread Ilya Dryomov
On Mon, May 25, 2015 at 5:04 PM, Christoph Hellwig h...@lst.de wrote: On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote: From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-24 Thread NeilBrown
On Fri, 22 May 2015 11:18:40 -0700 Ming Lin wrote: > From: Kent Overstreet > > As generic_make_request() is now able to handle arbitrarily sized bios, > it's no longer necessary for each individual block driver to define its > own ->merge_bvec_fn() callback. Remove every invocation completely.

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-24 Thread NeilBrown
On Fri, 22 May 2015 11:18:40 -0700 Ming Lin m...@kernel.org wrote: From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own -merge_bvec_fn() callback.

[PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-22 Thread Ming Lin
From: Kent Overstreet As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own ->merge_bvec_fn() callback. Remove every invocation completely. Cc: Jens Axboe Cc: Lars Ellenberg Cc:

[PATCH v4 08/11] block: kill merge_bvec_fn() completely

2015-05-22 Thread Ming Lin
From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own -merge_bvec_fn() callback. Remove every invocation completely. Cc: Jens Axboe ax...@kernel.dk Cc: