Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Westergreen, Dalon
On Tue, 2020-07-14 at 13:23 -0700, David Miller wrote: > From: "Westergreen, Dalon" > Date: Tue, 14 Jul 2020 18:51:15 + > > > I don't think this is necessary, i think just having a module parameter > > meets our needs. I don't see a need for the value to change on a per > > interface

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread David Miller
From: "Westergreen, Dalon" Date: Tue, 14 Jul 2020 18:51:15 + > I don't think this is necessary, i think just having a module parameter > meets our needs. I don't see a need for the value to change on a per > interface basis. This was primarily used during testing / bringup. Please no

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Jakub Kicinski
On Tue, 14 Jul 2020 18:51:15 + Westergreen, Dalon wrote: > > I've seen vendors abuse fields of ethtool --coalesce to configure > > similar settings. tx-usecs-irq and rx-usecs-irq, I think. Since this > > part of ethtool API has been ported to netlink, could we perhaps add > > a new field to

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Westergreen, Dalon
On Tue, 2020-07-14 at 09:29 -0700, Jakub Kicinski wrote: > On Tue, 14 Jul 2020 15:58:53 + Westergreen, Dalon wrote: > > On Tue, 2020-07-14 at 08:55 -0700, Jakub Kicinski wrote: > > > On Tue, 14 Jul 2020 14:35:16 + Ooi, Joyce wrote: > > > > > I'm no device tree expert but these look

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Jakub Kicinski
On Tue, 14 Jul 2020 15:58:53 + Westergreen, Dalon wrote: > On Tue, 2020-07-14 at 08:55 -0700, Jakub Kicinski wrote: > > On Tue, 14 Jul 2020 14:35:16 + Ooi, Joyce wrote: > > > > I'm no device tree expert but these look like config options rather than > > > > HW > > > > description. They

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Westergreen, Dalon
On Tue, 2020-07-14 at 08:55 -0700, Jakub Kicinski wrote: > On Tue, 14 Jul 2020 14:35:16 + Ooi, Joyce wrote: > > > I'm no device tree expert but these look like config options rather than > > > HW > > > description. They also don't appear to be documented in the next patch. > > > > The

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Jakub Kicinski
On Tue, 14 Jul 2020 14:35:16 + Ooi, Joyce wrote: > > I'm no device tree expert but these look like config options rather than HW > > description. They also don't appear to be documented in the next patch. > > The poll_freq are part of the msgdma prefetcher IP, whereby it > specifies the

RE: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Ooi, Joyce
Chin Liang ; > Nguyen, Dinh ; Westergreen, Dalon > > Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher > > From: "Ooi, Joyce" > Date: Wed, 8 Jul 2020 15:24:00 +0800 > > > +int msgdma_pref_initialize(struct altera_tse_private *priv) { > &g

RE: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Ooi, Joyce
gt; Nguyen, Dinh ; Westergreen, Dalon > > Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher > > On Wed, 8 Jul 2020 15:24:00 +0800 Ooi, Joyce wrote: > > + /* get prefetcher rx poll frequency from device tree */ > > + if (of

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-08 Thread Jakub Kicinski
On Wed, 8 Jul 2020 15:24:00 +0800 Ooi, Joyce wrote: > + /* get prefetcher rx poll frequency from device tree */ > + if (of_property_read_u32(pdev->dev.of_node, "rx-poll-freq", > + >rx_poll_freq)) { > + dev_info(>dev,

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-08 Thread David Miller
From: "Ooi, Joyce" Date: Wed, 8 Jul 2020 15:24:00 +0800 > +int msgdma_pref_initialize(struct altera_tse_private *priv) > +{ > + int i; > + struct msgdma_pref_extended_desc *rx_descs; > + struct msgdma_pref_extended_desc *tx_descs; > + dma_addr_t rx_descsphys; > + dma_addr_t

[PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-08 Thread Ooi, Joyce
From: Dalon Westergreen Add support for the mSGDMA prefetcher. The prefetcher adds support for a linked list of descriptors in system memory. The prefetcher feeds these to the mSGDMA dispatcher. The prefetcher is configured to poll for the next descriptor in the list to be owned by hardware,