Re: [PATCH v4 09/12] [media] vivid: Local optimization

2016-07-18 Thread Ricardo Ribalda Delgado
Hi Philipp: On Mon, Jul 18, 2016 at 4:16 PM, Philipp Zabel wrote: > I had the best looking result with this variant, btw: > > y >>= 4; > cb >>= 4; > cr >>= 4; > if (tpg->real_quantization == V4L2_QUANTIZATION_LIM_RANGE) { > y = clamp(y, 16, 235); >

Re: [PATCH v4 09/12] [media] vivid: Local optimization

2016-07-18 Thread Philipp Zabel
Hi Ricardo, Am Montag, den 18.07.2016, 15:21 +0200 schrieb Ricardo Ribalda Delgado: > Hi Philipp > > On Mon, Jul 18, 2016 at 3:13 PM, Philipp Zabel wrote: > > Since the constant expressions are evaluated at compile time, you are > > not actually removing shifts. The code generated for precalcula

Re: [PATCH v4 09/12] [media] vivid: Local optimization

2016-07-18 Thread Ricardo Ribalda Delgado
Hi Philipp On Mon, Jul 18, 2016 at 3:13 PM, Philipp Zabel wrote: > Since the constant expressions are evaluated at compile time, you are > not actually removing shifts. The code generated for precalculate_color > by gcc 5.4 even grows by one asr instruction with this patch. > I dont think that I

Re: [PATCH v4 09/12] [media] vivid: Local optimization

2016-07-18 Thread Philipp Zabel
Hi Ricardo, Am Montag, den 18.07.2016, 14:42 +0200 schrieb Ricardo Ribalda Delgado: > Avoid duplicated data shifts when possible. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-

[PATCH v4 09/12] [media] vivid: Local optimization

2016-07-18 Thread Ricardo Ribalda Delgado
Avoid duplicated data shifts when possible. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c b/drivers/media/common/v4l2-tpg/v4