15.09.2020 18:55, Wang, Jiada пишет:
...
>> Jiada, will you be able to re-work this patch? Please note that the new
>> "atmel,mXT1386" DT compatible needs to be added into the
>> atmel,maxtouch.txt binding.
>
> Yes, I can re-work this patch, and add one more change to dts-binding.
>
> to summariz
Hi Dmitry
On 2020/09/15 6:33, Dmitry Osipenko wrote:
14.09.2020 22:36, Dmitry Torokhov пишет:
On Mon, Sep 14, 2020 at 12:33:40PM -0700, Dmitry Torokhov wrote:
On Mon, Sep 14, 2020 at 08:29:44PM +0300, Dmitry Osipenko wrote:
13.09.2020 19:56, Dmitry Torokhov пишет:
Hi Jiada,
On Sat, Sep 12,
On Mon, Sep 14, 2020 at 4:32 PM Dmitry Torokhov
wrote:
>
> On Tue, Sep 15, 2020 at 12:33:18AM +0300, Dmitry Osipenko wrote:
> > 14.09.2020 22:36, Dmitry Torokhov пишет:
> > > On Mon, Sep 14, 2020 at 12:33:40PM -0700, Dmitry Torokhov wrote:
> > >> On Mon, Sep 14, 2020 at 08:29:44PM +0300, Dmitry Os
On Tue, Sep 15, 2020 at 12:33:18AM +0300, Dmitry Osipenko wrote:
> 14.09.2020 22:36, Dmitry Torokhov пишет:
> > On Mon, Sep 14, 2020 at 12:33:40PM -0700, Dmitry Torokhov wrote:
> >> On Mon, Sep 14, 2020 at 08:29:44PM +0300, Dmitry Osipenko wrote:
> >>> 13.09.2020 19:56, Dmitry Torokhov пишет:
> >>>
14.09.2020 22:36, Dmitry Torokhov пишет:
> On Mon, Sep 14, 2020 at 12:33:40PM -0700, Dmitry Torokhov wrote:
>> On Mon, Sep 14, 2020 at 08:29:44PM +0300, Dmitry Osipenko wrote:
>>> 13.09.2020 19:56, Dmitry Torokhov пишет:
Hi Jiada,
On Sat, Sep 12, 2020 at 09:55:21AM +0900, Jiada Wang
On Mon, Sep 14, 2020 at 12:33:40PM -0700, Dmitry Torokhov wrote:
> On Mon, Sep 14, 2020 at 08:29:44PM +0300, Dmitry Osipenko wrote:
> > 13.09.2020 19:56, Dmitry Torokhov пишет:
> > > Hi Jiada,
> > >
> > > On Sat, Sep 12, 2020 at 09:55:21AM +0900, Jiada Wang wrote:
> > >> From: Nick Dyer
> > >>
>
On Mon, Sep 14, 2020 at 08:29:44PM +0300, Dmitry Osipenko wrote:
> 13.09.2020 19:56, Dmitry Torokhov пишет:
> > Hi Jiada,
> >
> > On Sat, Sep 12, 2020 at 09:55:21AM +0900, Jiada Wang wrote:
> >> From: Nick Dyer
> >>
> >> Some maXTouch chips (eg mXT1386) will not respond on the first I2C request
>
13.09.2020 19:56, Dmitry Torokhov пишет:
> Hi Jiada,
>
> On Sat, Sep 12, 2020 at 09:55:21AM +0900, Jiada Wang wrote:
>> From: Nick Dyer
>>
>> Some maXTouch chips (eg mXT1386) will not respond on the first I2C request
>> when they are in a sleep state. It must be retried after a delay for the
>> c
14.09.2020 18:50, Andy Shevchenko пишет:
...
>> It's more preferred
>> to accept patch as-is if it does right thing and then maintainer could
>> modify the patch, making cosmetic changes.
>
> It depends on the maintainer's workflow (which may be different from
> maintainer to maintainer).
Sure!
On Mon, Sep 14, 2020 at 6:26 PM Dmitry Osipenko wrote:
> 14.09.2020 16:49, Andy Shevchenko пишет:
> > On Sun, Sep 13, 2020 at 3:57 PM Dmitry Osipenko wrote:
...
> + ret = i2c_transfer(client->adapter, xfer, ARRAY_SIZE(xfer));
> + if (ret != ARRAY_SIZE(xfer)) {
> >> ...> Al
14.09.2020 16:49, Andy Shevchenko пишет:
> On Sun, Sep 13, 2020 at 3:57 PM Dmitry Osipenko wrote:
>>
>> 13.09.2020 11:43, Andy Shevchenko пишет:
>>> ...
>>>
+ bool retried = false;
>>
>>> I thought Dmitry wants that to be retry
>>
>> In the comment to v2 you suggested to negate the cond
On Sun, Sep 13, 2020 at 3:57 PM Dmitry Osipenko wrote:
>
> 13.09.2020 11:43, Andy Shevchenko пишет:
> > ...
> >
> >> + bool retried = false;
>
> > I thought Dmitry wants that to be retry
>
> In the comment to v2 you suggested to negate the condition,
Where? I just checked a few messages bef
Hi Jiada,
On Sat, Sep 12, 2020 at 09:55:21AM +0900, Jiada Wang wrote:
> From: Nick Dyer
>
> Some maXTouch chips (eg mXT1386) will not respond on the first I2C request
> when they are in a sleep state. It must be retried after a delay for the
> chip to wake up.
Do we know when the chip is in sle
13.09.2020 11:43, Andy Shevchenko пишет:
> ...
>
>> + bool retried = false;
> I thought Dmitry wants that to be retry
In the comment to v2 you suggested to negate the condition, hence I
thought it's YOU who wants it to be retried.
The "retried" is a very common form among kernel drivers,
On Sat, Sep 12, 2020 at 3:55 AM Jiada Wang wrote:
>
> From: Nick Dyer
>
> Some maXTouch chips (eg mXT1386) will not respond on the first I2C request
> when they are in a sleep state. It must be retried after a delay for the
> chip to wake up.
>
> Signed-off-by: Nick Dyer
> [gdavis: Forward port
From: Nick Dyer
Some maXTouch chips (eg mXT1386) will not respond on the first I2C request
when they are in a sleep state. It must be retried after a delay for the
chip to wake up.
Signed-off-by: Nick Dyer
[gdavis: Forward port and fix conflicts.]
Signed-off-by: George G. Davis
[jiada: return
16 matches
Mail list logo
