Re: [PATCH v4 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2

2020-09-01 Thread Liam Beguin
Hi Vinod, On Mon Aug 31, 2020 at 7:08 AM EDT, Vinod Koul wrote: > Hi Liam, > > On 22-08-20, 16:53, Liam Beguin wrote: > > From: Liam Beguin > > > > Start by reading the content of the VENDOR_SPECIFIC2 register and update > > each bit field based on device properties when defined. > > > > The

Re: [PATCH v4 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2

2020-09-01 Thread Liam Beguin
Hi Vinod, On Mon Aug 31, 2020 at 7:08 AM EDT, Vinod Koul wrote: > Hi Liam, > > On 22-08-20, 16:53, Liam Beguin wrote: > > From: Liam Beguin > > > > Start by reading the content of the VENDOR_SPECIFIC2 register and update > > each bit field based on device properties when defined. > > > > The

Re: [PATCH v4 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2

2020-08-31 Thread Vinod Koul
Hi Liam, On 22-08-20, 16:53, Liam Beguin wrote: > From: Liam Beguin > > Start by reading the content of the VENDOR_SPECIFIC2 register and update > each bit field based on device properties when defined. > > The use of bit masks prevents fields from overriding each other and > enables users to

[PATCH v4 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2

2020-08-22 Thread Liam Beguin
From: Liam Beguin Start by reading the content of the VENDOR_SPECIFIC2 register and update each bit field based on device properties when defined. The use of bit masks prevents fields from overriding each other and enables users to clear bits which are set by default, like datapolarity in this