Re: [PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-07-08 Thread eric ernst
Mea culpa - thanks Linus. I saw a note from kbuild test robot indicating an issue, but given your response, I am assuming it was from your first build attempt. Thanks. On 14-07-07 02:14 PM, Linus Walleij wrote: On Thu, Jun 12, 2014 at 8:06 PM, wrote: + WARN(readl(conf_reg) &

Re: [PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-07-08 Thread eric ernst
Mea culpa - thanks Linus. I saw a note from kbuild test robot indicating an issue, but given your response, I am assuming it was from your first build attempt. Thanks. On 14-07-07 02:14 PM, Linus Walleij wrote: On Thu, Jun 12, 2014 at 8:06 PM, eric.er...@linux.intel.com wrote: +

Re: [PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-07-07 Thread Linus Walleij
On Thu, Jun 12, 2014 at 8:06 PM, wrote: > + WARN(readl(conf_reg) & BYT_DIRECT_IRQ_EN, > + "Potential Error: Setting GPIO with direct_irq_en to output"); Hm in the v4 version you somehow managed to drop the definition of BYT_DIRECT_IRQ_EN... I patched it back in. Let's hope

Re: [PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-07-07 Thread Linus Walleij
On Thu, Jun 12, 2014 at 8:06 PM, wrote: > From: Eric Ernst > > For Baytrail, you should never set a GPIO set to direct_irq > to output mode. When direct_irq_en is set for a GPIO, it is > tied directly to an APIC internally, and making the pad output > does not make any sense. Assert a WARN()

Re: [PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-07-07 Thread Linus Walleij
On Thu, Jun 12, 2014 at 8:06 PM, eric.er...@linux.intel.com wrote: From: Eric Ernst eric.er...@linux.intel.com For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the pad

Re: [PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-07-07 Thread Linus Walleij
On Thu, Jun 12, 2014 at 8:06 PM, eric.er...@linux.intel.com wrote: + WARN(readl(conf_reg) BYT_DIRECT_IRQ_EN, + Potential Error: Setting GPIO with direct_irq_en to output); Hm in the v4 version you somehow managed to drop the definition of BYT_DIRECT_IRQ_EN... I patched

[PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-06-12 Thread eric . ernst
From: Eric Ernst For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the pad output does not make any sense. Assert a WARN() in the event this happens. Signed-off-by: Eric Ernst

[PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-06-12 Thread eric . ernst
From: Eric Ernst eric.er...@linux.intel.com For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the pad output does not make any sense. Assert a WARN() in the event this happens.