Re: [PATCH v4 1/1] power/supply/sbs-battery: Fix confusing battery status when idle or empty

2019-09-02 Thread Sebastian Reichel
Hi, Looks good to me, but needs to be split (one patch adding STATUS_EMPTY to the power-supply core and one patch fixing sbs-battery driver). -- Sebastian On Thu, Aug 01, 2019 at 12:34:18PM -0600, Nick Crews wrote: > Thanks Richard, I still would like some more opinions > on this changing the us

Re: [PATCH v4 1/1] power/supply/sbs-battery: Fix confusing battery status when idle or empty

2019-08-01 Thread Nick Crews
Thanks Richard, I still would like some more opinions on this changing the userspace experience, but LGTM otherwise. Reviewed-by: Nick Crews On Mon, Jul 29, 2019 at 8:00 PM Richard Tresidder wrote: > > When a battery or batteries in a system are in parallel then one or more > may not be providi

[PATCH v4 1/1] power/supply/sbs-battery: Fix confusing battery status when idle or empty

2019-07-29 Thread Richard Tresidder
When a battery or batteries in a system are in parallel then one or more may not be providing any current to the system. This fixes an incorrect status indication of FULL for the battery simply because it wasn't discharging at that point in time. The battery will now be flagged as NOT CHARGING. Hav