Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Thu, Feb 4, 2016 at 12:02 AM, Marcel Ziswiler wrote: > On Wed, 2016-02-03 at 23:55 +0100, Marcel Ziswiler wrote: >> On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: >> >> [snip] >> >> > + /* STMPE811 touch screen controller */ >> > > + stmpe811@41 { >> > > + compatible =

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Thu, Feb 4, 2016 at 12:02 AM, Marcel Ziswiler wrote: > On Wed, 2016-02-03 at 23:55 +0100, Marcel Ziswiler wrote: >> On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: >> >> [snip] >> >> > + /* STMPE811 touch screen controller */ >> > > + stmpe811@41 { >> > > +

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: [snip] > > + stmpe_touchscreen { > > Shouldn't the node name be generic as just touchscreen?  Or at least, > hyphen instead of underscore should be used in node name. This one is actually as per binding document example:

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

Hi Petr On Mon, 2016-01-25 at 10:46 +0100, Petr Štetiar wrote: [snip] > What problems are you having if you remove that parent regulators > node? To be honest I don't remember the exact issues it caused. I just tried again now with latest next-20160203 and besides slab being broken it worked

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Wed, 2016-02-03 at 23:55 +0100, Marcel Ziswiler wrote: > On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: > > [snip] > > > + /* STMPE811 touch screen controller */ > > > + stmpe811@41 { > > > + compatible = "st,stmpe811"; > > > > The compatible seems to be used by kernel without

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: [snip] > + /* STMPE811 touch screen controller */ > > + stmpe811@41 { > > + compatible = "st,stmpe811"; > > The compatible seems to be used by kernel without a binding document. Indeed and looking at git logs Linus himself

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Wed, 2016-02-03 at 23:55 +0100, Marcel Ziswiler wrote: > On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: > > [snip] > > > + /* STMPE811 touch screen controller */ > > > + stmpe811@41 { > > > + compatible = "st,stmpe811"; > > > > The compatible seems to be used by kernel without

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: [snip] > > + stmpe_touchscreen { > > Shouldn't the node name be generic as just touchscreen?  Or at least, > hyphen instead of underscore should be used in node name. This one is actually as per binding document example:

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: [snip] > + /* STMPE811 touch screen controller */ > > + stmpe811@41 { > > + compatible = "st,stmpe811"; > > The compatible seems to be used by kernel without a binding document. Indeed and looking at git logs Linus himself

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

Hi Petr On Mon, 2016-01-25 at 10:46 +0100, Petr Štetiar wrote: [snip] > What problems are you having if you remove that parent regulators > node? To be honest I don't remember the exact issues it caused. I just tried again now with latest next-20160203 and besides slab being broken it worked

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Sun, Jan 24, 2016 at 11:48:22PM +0100, Marcel Ziswiler wrote: > From: Petr Štetiar > > Signed-off-by: Marcel Ziswiler > Signed-off-by: Petr Štetiar > Reviewed-by: Stefan Agner > --- > > Changes in v4: > - integrated review feedback from Fabio > > Changes in v3: > - integrated review

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

On Sun, Jan 24, 2016 at 11:48:22PM +0100, Marcel Ziswiler wrote: > From: Petr Štetiar > > Signed-off-by: Marcel Ziswiler > Signed-off-by: Petr Štetiar > Reviewed-by: Stefan Agner > --- > > Changes in v4: > -

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

Marcel Ziswiler [2016-01-24 23:48:22]: Hi Marcel, sorry for not commenting on your v3, I've missed it :( > + regulators { > + compatible = "simple-bus"; > + I've commented this on your v2 already. One of the Lucas's comments[1] about this node was following: "Get rid of

Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

Marcel Ziswiler [2016-01-24 23:48:22]: Hi Marcel, sorry for not commenting on your v3, I've missed it :( > + regulators { > + compatible = "simple-bus"; > + I've commented this on your v2 already. One of the Lucas's comments[1] about this node was

[PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

From: Petr Štetiar Signed-off-by: Marcel Ziswiler Signed-off-by: Petr Štetiar Reviewed-by: Stefan Agner --- Changes in v4: - integrated review feedback from Fabio Changes in v3: - integrated review feedback from Petr - integrated review feedback from Stefan - move I2C DDC enablement and

[PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

From: Petr Štetiar Signed-off-by: Marcel Ziswiler Signed-off-by: Petr Štetiar Reviewed-by: Stefan Agner --- Changes in v4: - integrated review feedback from Fabio Changes in v3: - integrated review feedback from