Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-12 Thread Karim Yaghmour
Hi Geert, On 3/11/19 4:03 AM, Geert Uytterhoeven wrote: [ snip ] OK. Now about the actual solution: what is your opinion on embedding e.g. a squashfs image in the kernel instead, which would be a more generic solution, not adding more ABI to /proc? I'm not familiar enough with the

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-11 Thread Joel Fernandes
On Mon, Mar 11, 2019 at 04:58:28PM -0700, Daniel Colascione wrote: > On Mon, Mar 11, 2019 at 4:37 PM Steven Rostedt wrote: > > > > On Sat, 9 Mar 2019 16:44:31 -0500 > > Karim Yaghmour wrote: > > > > > > > Sorry, I should've been clearer. I'm including eBPF/BCC into the > > > "user-space tools"

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-09 Thread Karim Yaghmour
Hi Geert, On 3/9/19 2:26 PM, Geert Uytterhoeven wrote: Thanks for the explanation! Happy this was useful :) So how does this work, with kernel images and kernel modules supplied by separate parties, not "bound" by the same kernel headers/API, as they can be replaced separately? The

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-09 Thread Geert Uytterhoeven
Hi Karim, Thanks for the explanation! On Sat, Mar 9, 2019 at 5:52 PM Karim Yaghmour wrote: > On 3/9/19 7:11 AM, Greg KH wrote: > > There is no licensing issue, see my follow-up comment about that. > > > > It's all in ease-of-use here. You want to build a trace function > > against a running

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-09 Thread Karim Yaghmour
On 3/9/19 7:11 AM, Greg KH wrote: There is no licensing issue, see my follow-up comment about that. It's all in ease-of-use here. You want to build a trace function against a running kernel, and now you have the header files for that specific kernel right there in the kernel itself to build

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-09 Thread Greg KH
On Sat, Mar 09, 2019 at 12:40:01PM +0100, Geert Uytterhoeven wrote: > > Signing keys should be kept secure, or better yet, just deleted entirely > > after creating and signing with them. That's what I do for my kernels > > and I'm pretty sure that some distros also do this. That way there's no >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-09 Thread Geert Uytterhoeven
Hi Greg, On Sat, Mar 9, 2019 at 8:16 AM Greg KH wrote: > On Fri, Mar 08, 2019 at 06:59:23PM +0100, Geert Uytterhoeven wrote: > > On Fri, Mar 8, 2019 at 6:05 PM Greg KH wrote: > > > On Fri, Mar 08, 2019 at 05:42:32AM -0800, Joel Fernandes wrote: > > > > On Fri, Mar 8, 2019, 3:53 AM Geert

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Greg KH
On Fri, Mar 08, 2019 at 06:59:23PM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, Mar 8, 2019 at 6:05 PM Greg KH wrote: > > On Fri, Mar 08, 2019 at 05:42:32AM -0800, Joel Fernandes wrote: > > > On Fri, Mar 8, 2019, 3:53 AM Geert Uytterhoeven > > > wrote: > > > > > It is just so much

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Geert Uytterhoeven
Hi Greg, On Fri, Mar 8, 2019 at 6:05 PM Greg KH wrote: > On Fri, Mar 08, 2019 at 05:42:32AM -0800, Joel Fernandes wrote: > > On Fri, Mar 8, 2019, 3:53 AM Geert Uytterhoeven > > wrote: > > > > It is just so much easier to use tar + xz at build time, and leave the > > > > decompression task to

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Joel Fernandes
On Fri, Mar 08, 2019 at 03:02:51PM +0100, Greg KH wrote: > On Fri, Mar 08, 2019 at 05:42:32AM -0800, Joel Fernandes wrote: > > HI Geert, > > > > On Fri, Mar 8, 2019, 3:53 AM Geert Uytterhoeven > > wrote: > > > > It is just so much easier to use tar + xz at build time, and leave the > > > >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Greg KH
On Fri, Mar 08, 2019 at 02:57:24PM +0100, Enrico Weigelt, metux IT consult wrote: > On 08.03.19 14:42, Joel Fernandes wrote: > > Hi folks, > > > That sounds like it could be useful. I don't see any reason off the > > top why that would not be possible to add to the list of archived > > files in

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Greg KH
On Fri, Mar 08, 2019 at 05:42:32AM -0800, Joel Fernandes wrote: > HI Geert, > > On Fri, Mar 8, 2019, 3:53 AM Geert Uytterhoeven wrote: > > > It is just so much easier to use tar + xz at build time, and leave the > > > decompression task to the user. After decompression, the files will live > >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Enrico Weigelt, metux IT consult
On 08.03.19 14:42, Joel Fernandes wrote: Hi folks, > That sounds like it could be useful. I don't see any reason off the > top why that would not be possible to add to the list of archived > files in the future. The patch allows populating the list of files > from Kbuild using ikh_file_list

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Joel Fernandes
HI Geert, On Fri, Mar 8, 2019, 3:53 AM Geert Uytterhoeven wrote: > > It is just so much easier to use tar + xz at build time, and leave the > > decompression task to the user. After decompression, the files will live on > > the disk and the page-cache mechanism will free memory when/if the files

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Geert Uytterhoeven
Hi Joel, On Thu, Mar 7, 2019 at 4:03 PM Joel Fernandes wrote: > On Thu, Mar 07, 2019 at 09:58:24AM +0100, Geert Uytterhoeven wrote: > > On Fri, Mar 1, 2019 at 5:10 PM Joel Fernandes (Google) > > wrote: > > > Introduce in-kernel headers and other artifacts which are made available > > > as an

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Justin Capella
Would you consider this more reliable than the make install_headers, and am curious about DKMS applications / whether this should be preferable to the /lib/modules/kernver/biuld symlinks On Wed, Mar 6, 2019 at 6:48 AM Masahiro Yamada wrote: > > On Mon, Mar 4, 2019 at 1:15 AM Joel Fernandes

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Joel Fernandes
On Thu, Mar 07, 2019 at 04:23:03PM +0100, Greg KH wrote: > > > On Fri, Mar 1, 2019 at 5:10 PM Joel Fernandes (Google) > > > wrote: > > > > Introduce in-kernel headers and other artifacts which are made available > > > > as an archive through proc (/proc/kheaders.tar.xz file). This archive > > >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Greg KH
On Thu, Mar 07, 2019 at 10:03:43AM -0500, Joel Fernandes wrote: > On Thu, Mar 07, 2019 at 09:58:24AM +0100, Geert Uytterhoeven wrote: > > Hi Joel, > > > > On Fri, Mar 1, 2019 at 5:10 PM Joel Fernandes (Google) > > wrote: > > > Introduce in-kernel headers and other artifacts which are made

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Joel Fernandes
On Thu, Mar 07, 2019 at 09:58:24AM +0100, Geert Uytterhoeven wrote: > Hi Joel, > > On Fri, Mar 1, 2019 at 5:10 PM Joel Fernandes (Google) > wrote: > > Introduce in-kernel headers and other artifacts which are made available > > as an archive through proc (/proc/kheaders.tar.xz file). This

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Joel Fernandes
On Thu, Mar 07, 2019 at 01:59:12PM +0900, Masahiro Yamada wrote: [snip] > > > [2] > > > > > > The shell script keeps running > > > even when an error occurs. > > > > > > If any line in a shell script fails, > > > probably it went already wrong. > > > > > > I highly recommend to add 'set -e' > > >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Geert Uytterhoeven
Hi Joel, On Fri, Mar 1, 2019 at 5:10 PM Joel Fernandes (Google) wrote: > Introduce in-kernel headers and other artifacts which are made available > as an archive through proc (/proc/kheaders.tar.xz file). This archive makes > it possible to build kernel modules, run eBPF programs, and other >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-06 Thread Masahiro Yamada
On Thu, Mar 7, 2019 at 5:13 AM Joel Fernandes wrote: > > Hi Masahiro, > Thanks for review, my replies are inline: > > On Wed, Mar 06, 2019 at 09:26:14PM +0900, Masahiro Yamada wrote: > > On Mon, Mar 4, 2019 at 1:15 AM Joel Fernandes wrote: > > > > > > This report is for an older version of the

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-06 Thread Masahiro Yamada
On Thu, Mar 7, 2019 at 5:31 AM Joel Fernandes wrote: > > > > On Sat, Mar 2, 2019 at 2:00 PM kbuild test robot wrote: > > > > > > Hi Joel, > > > > > > Thank you for the patch! Yet something to improve: > > > > > > [auto build test ERROR on linus/master] > > > [also build test ERROR on v5.0-rc8] >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-06 Thread Joel Fernandes
> On Sat, Mar 2, 2019 at 2:00 PM kbuild test robot wrote: > > > > Hi Joel, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on linus/master] > > [also build test ERROR on v5.0-rc8] > > [cannot apply to next-20190301] > > [if your patch is applied to the

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-06 Thread Joel Fernandes
Hi Masahiro, Thanks for review, my replies are inline: On Wed, Mar 06, 2019 at 09:26:14PM +0900, Masahiro Yamada wrote: > On Mon, Mar 4, 2019 at 1:15 AM Joel Fernandes wrote: > > > > This report is for an older version of the patch so ignore it. The > > issue is already resolved. > > > > On Sat,

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-06 Thread Masahiro Yamada
On Mon, Mar 4, 2019 at 1:15 AM Joel Fernandes wrote: > > This report is for an older version of the patch so ignore it. The > issue is already resolved. > > On Sat, Mar 2, 2019 at 2:00 PM kbuild test robot wrote: > > > > Hi Joel, > > > > Thank you for the patch! Yet something to improve: > > > >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-05 Thread Joel Fernandes
On Mon, Mar 04, 2019 at 02:00:59PM +, Qais Yousef wrote: > On 03/01/19 11:08, Joel Fernandes (Google) wrote: > > Introduce in-kernel headers and other artifacts which are made available > > as an archive through proc (/proc/kheaders.tar.xz file). This archive makes > > it possible to build

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-05 Thread Joel Fernandes
On Mon, Mar 04, 2019 at 11:48:52PM +0100, Dietmar Eggemann wrote: > On 3/1/19 5:08 PM, Joel Fernandes (Google) wrote: > > Introduce in-kernel headers and other artifacts which are made available > > as an archive through proc (/proc/kheaders.tar.xz file). This archive makes > > it possible to

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-04 Thread Dietmar Eggemann
On 3/1/19 5:08 PM, Joel Fernandes (Google) wrote: Introduce in-kernel headers and other artifacts which are made available as an archive through proc (/proc/kheaders.tar.xz file). This archive makes it possible to build kernel modules, run eBPF programs, and other tracing programs that need to

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-04 Thread Qais Yousef
On 03/01/19 11:08, Joel Fernandes (Google) wrote: > Introduce in-kernel headers and other artifacts which are made available > as an archive through proc (/proc/kheaders.tar.xz file). This archive makes > it possible to build kernel modules, run eBPF programs, and other > tracing programs that

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-03 Thread Joel Fernandes
This report is for an older version of the patch so ignore it. The issue is already resolved. On Sat, Mar 2, 2019 at 2:00 PM kbuild test robot wrote: > > Hi Joel, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-02 Thread kbuild test robot
Hi Joel, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc8] [cannot apply to next-20190301] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-02 Thread kbuild test robot
Hi Joel, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc8] [cannot apply to next-20190301] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-01 Thread Joel Fernandes (Google)
Introduce in-kernel headers and other artifacts which are made available as an archive through proc (/proc/kheaders.tar.xz file). This archive makes it possible to build kernel modules, run eBPF programs, and other tracing programs that need to extend the kernel for tracing purposes without any