Re: [PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2017-01-13 Thread Serge Semin
On Fri, Jan 13, 2017 at 08:22:35AM +0100, Greg KH wrote: > On Fri, Jan 13, 2017 at 01:54:17AM +0300, Serge Semin wrote: > > On Wed, Jan 11, 2017 at 09:21:19AM +0100, Greg KH > > wrote: > > > > + /* Return failure if root directory

Re: [PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2017-01-13 Thread Serge Semin
On Fri, Jan 13, 2017 at 08:22:35AM +0100, Greg KH wrote: > On Fri, Jan 13, 2017 at 01:54:17AM +0300, Serge Semin wrote: > > On Wed, Jan 11, 2017 at 09:21:19AM +0100, Greg KH > > wrote: > > > > + /* Return failure if root directory doesn't exist */ > > > > + if (!csr_dbgdir) { > > >

Re: [PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2017-01-12 Thread Greg KH
On Fri, Jan 13, 2017 at 01:54:17AM +0300, Serge Semin wrote: > On Wed, Jan 11, 2017 at 09:21:19AM +0100, Greg KH > wrote: > > > + /* Return failure if root directory doesn't exist */ > > > + if (!csr_dbgdir) { > > > + dev_dbg(dev, "No Debugfs root directory");

Re: [PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2017-01-12 Thread Greg KH
On Fri, Jan 13, 2017 at 01:54:17AM +0300, Serge Semin wrote: > On Wed, Jan 11, 2017 at 09:21:19AM +0100, Greg KH > wrote: > > > + /* Return failure if root directory doesn't exist */ > > > + if (!csr_dbgdir) { > > > + dev_dbg(dev, "No Debugfs root directory"); > > > + return

Re: [PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2017-01-12 Thread Serge Semin
On Wed, Jan 11, 2017 at 09:21:19AM +0100, Greg KH wrote: > On Tue, Dec 13, 2016 at 05:22:50PM +0300, Serge Semin wrote: > > +struct idt_89hpesx_dev { > > + u32 eesize; > > + bool eero; > > + u8 eeaddr; > > + > > + u8 inieecmd; > > + u8 inicsrcmd; > > + u8

Re: [PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2017-01-12 Thread Serge Semin
On Wed, Jan 11, 2017 at 09:21:19AM +0100, Greg KH wrote: > On Tue, Dec 13, 2016 at 05:22:50PM +0300, Serge Semin wrote: > > +struct idt_89hpesx_dev { > > + u32 eesize; > > + bool eero; > > + u8 eeaddr; > > + > > + u8 inieecmd; > > + u8 inicsrcmd; > > + u8 iniccode; > > + > > +

Re: [PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2017-01-11 Thread Greg KH
On Tue, Dec 13, 2016 at 05:22:50PM +0300, Serge Semin wrote: > +struct idt_89hpesx_dev { > + u32 eesize; > + bool eero; > + u8 eeaddr; > + > + u8 inieecmd; > + u8 inicsrcmd; > + u8 iniccode; > + > + atomic_t csr; Why is this an atomic_t and not just a "normal" u32 or

Re: [PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2017-01-11 Thread Greg KH
On Tue, Dec 13, 2016 at 05:22:50PM +0300, Serge Semin wrote: > +struct idt_89hpesx_dev { > + u32 eesize; > + bool eero; > + u8 eeaddr; > + > + u8 inieecmd; > + u8 inicsrcmd; > + u8 iniccode; > + > + atomic_t csr; Why is this an atomic_t and not just a "normal" u32 or

[PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2016-12-13 Thread Serge Semin
This driver provides an access to EEPROM of IDT PCIe-switches. IDT PCIe- switches expose a simple SMBus interface to perform IO-operations from/to EEPROM, which is located at private (so called Master) SMBus. The driver creates a simple binary sysfs-file to have an access to the EEPROM using the

[PATCH v4 1/2] eeprom: Add IDT 89HPESx EEPROM/CSR driver

2016-12-13 Thread Serge Semin
This driver provides an access to EEPROM of IDT PCIe-switches. IDT PCIe- switches expose a simple SMBus interface to perform IO-operations from/to EEPROM, which is located at private (so called Master) SMBus. The driver creates a simple binary sysfs-file to have an access to the EEPROM using the