Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-07-23 Thread Marek Vasut
On Thursday, July 24, 2014 at 05:19:27 AM, Yao Yuan wrote: > On Fri, May 21, 2014 at 4:01 PM +0200, Wolfram Sang wrote: > > Ping. Any updates? I think this was pretty close to inclusion? > > Hi, Wolfram > Thanks for your concern. Sorry for my reply so late. I had on a business > trip for

RE: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-07-23 Thread Yao Yuan
On Fri, May 21, 2014 at 4:01 PM +0200, Wolfram Sang wrote: > > Ping. Any updates? I think this was pretty close to inclusion? Hi, Wolfram Thanks for your concern. Sorry for my reply so late. I had on a business trip for months. At that time I have no device to debug it. Now, I'm come

RE: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-07-23 Thread Yao Yuan
On Fri, May 21, 2014 at 4:01 PM +0200, Wolfram Sang wrote: Ping. Any updates? I think this was pretty close to inclusion? Hi, Wolfram Thanks for your concern. Sorry for my reply so late. I had on a business trip for months. At that time I have no device to debug it. Now, I'm come back

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-07-23 Thread Marek Vasut
On Thursday, July 24, 2014 at 05:19:27 AM, Yao Yuan wrote: On Fri, May 21, 2014 at 4:01 PM +0200, Wolfram Sang wrote: Ping. Any updates? I think this was pretty close to inclusion? Hi, Wolfram Thanks for your concern. Sorry for my reply so late. I had on a business trip for months.

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-05-21 Thread Wolfram Sang
On Fri, Apr 04, 2014 at 07:40:11PM +0200, Wolfram Sang wrote: > > The ugly is my work or even the ability but not the attitude, I think. > > Explaining which tests were done is what I wanted to request more often > from submitters anyhow. Your leftover (yes, this can happen) just > reminded me to

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-05-21 Thread Wolfram Sang
On Fri, Apr 04, 2014 at 07:40:11PM +0200, Wolfram Sang wrote: The ugly is my work or even the ability but not the attitude, I think. Explaining which tests were done is what I wanted to request more often from submitters anyhow. Your leftover (yes, this can happen) just reminded me to

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Wolfram Sang
> The ugly is my work or even the ability but not the attitude, I think. Explaining which tests were done is what I wanted to request more often from submitters anyhow. Your leftover (yes, this can happen) just reminded me to actually do that :) signature.asc Description: Digital signature

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Yao Yuan
On Friday, April 04, 2014 at 22:29:32 PM, Marek Vasut wrote: > On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote: > > Add dma support for i2c. This function depend on DMA driver. > > You can turn on it by write both the dmas and dma-name properties in dts > > node. > > > > Signed-off-by:

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Wolfram Sang
On Fri, Apr 04, 2014 at 04:28:55PM +0200, Marek Vasut wrote: > On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote: > > Add dma support for i2c. This function depend on DMA driver. > > You can turn on it by write both the dmas and dma-name properties in dts > > node. > > > > Signed-off-by:

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Marek Vasut
On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote: > Add dma support for i2c. This function depend on DMA driver. > You can turn on it by write both the dmas and dma-name properties in dts > node. > > Signed-off-by: Yuan Yao [...] Since you will be fixing that superfluous return 0; (I

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Marek Vasut
On Friday, April 04, 2014 at 11:49:39 AM, sourav wrote: [...] > > +/* Functions for DMA support */ > > +static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, > > + dma_addr_t phy_addr) > > +{ > > + struct imx_i2c_dma *dma; > > + struct

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread sourav
+ +dma->chan_tx = dma_request_slave_channel(dev, "tx"); +return 0; To be more clear, return here looks to be some leftover. ?? Looks to be some leftover? +if (!dma->chan_tx) { +dev_info(dev, "DMA tx channel request failed\n"); +ret = -ENODEV; +goto

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread sourav
Hi, On Friday 04 April 2014 08:11 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao --- drivers/i2c/busses/i2c-imx.c | 372

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread sourav
Hi, On Friday 04 April 2014 08:11 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yaoyao.y...@freescale.com --- drivers/i2c/busses/i2c-imx.c | 372

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread sourav
+ +dma-chan_tx = dma_request_slave_channel(dev, tx); +return 0; To be more clear, return here looks to be some leftover. ?? Looks to be some leftover? +if (!dma-chan_tx) { +dev_info(dev, DMA tx channel request failed\n); +ret = -ENODEV; +goto fail_al; +

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Marek Vasut
On Friday, April 04, 2014 at 11:49:39 AM, sourav wrote: [...] +/* Functions for DMA support */ +static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, + dma_addr_t phy_addr) +{ + struct imx_i2c_dma *dma; + struct dma_slave_config

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Marek Vasut
On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao yao.y...@freescale.com [...] Since you will be fixing that

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Wolfram Sang
On Fri, Apr 04, 2014 at 04:28:55PM +0200, Marek Vasut wrote: On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Yao Yuan
On Friday, April 04, 2014 at 22:29:32 PM, Marek Vasut wrote: On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Wolfram Sang
The ugly is my work or even the ability but not the attitude, I think. Explaining which tests were done is what I wanted to request more often from submitters anyhow. Your leftover (yes, this can happen) just reminded me to actually do that :) signature.asc Description: Digital signature

[PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-03 Thread Yuan Yao
Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao --- drivers/i2c/busses/i2c-imx.c | 372 +-- 1 file changed, 319 insertions(+), 53

[PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-03 Thread Yuan Yao
Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao yao.y...@freescale.com --- drivers/i2c/busses/i2c-imx.c | 372 +-- 1 file changed, 319