Re: [PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation

2018-02-25 Thread Jacek Anaszewski
Hi Florian, Thanks for the v4. On 02/21/2018 10:46 PM, Florian Vaussard wrote: > Add device tree binding documentation for On Semiconductor NCP5623 I2C > LED driver. The driver can independently control the PWM of the 3 > channels with 32 levels of intensity. > > The current delivered by the

Re: [PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation

2018-02-25 Thread Jacek Anaszewski
Hi Florian, Thanks for the v4. On 02/21/2018 10:46 PM, Florian Vaussard wrote: > Add device tree binding documentation for On Semiconductor NCP5623 I2C > LED driver. The driver can independently control the PWM of the 3 > channels with 32 levels of intensity. > > The current delivered by the

Re: [PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation

2018-02-24 Thread Pavel Machek
Hi! > +Required properties: > + - compatible: Should be "onnn,ncp5623" > + - reg: I2C slave address (fixed to 0x38) .. > +Required properties: > + - reg : LED channel number (0..2) For consistency, there should be no space between reg and :. Anyway, this can be fixed later. Acked-by: Pavel

Re: [PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation

2018-02-24 Thread Pavel Machek
Hi! > +Required properties: > + - compatible: Should be "onnn,ncp5623" > + - reg: I2C slave address (fixed to 0x38) .. > +Required properties: > + - reg : LED channel number (0..2) For consistency, there should be no space between reg and :. Anyway, this can be fixed later. Acked-by: Pavel

[PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation

2018-02-21 Thread Florian Vaussard
Add device tree binding documentation for On Semiconductor NCP5623 I2C LED driver. The driver can independently control the PWM of the 3 channels with 32 levels of intensity. The current delivered by the current source can also be controlled. To do so, the led-max-microamp property is used by

[PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation

2018-02-21 Thread Florian Vaussard
Add device tree binding documentation for On Semiconductor NCP5623 I2C LED driver. The driver can independently control the PWM of the 3 channels with 32 levels of intensity. The current delivered by the current source can also be controlled. To do so, the led-max-microamp property is used by