Re: [PATCH v4 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2021-01-18 Thread Vijayanand Jitta
On 1/5/2021 2:54 PM, Vijayanand Jitta wrote: > > > On 1/5/2021 4:42 AM, Andrew Morton wrote: >> On Wed, 30 Dec 2020 18:15:30 +0530 vji...@codeaurora.org wrote: >> >>> Use STACK_HASH_ORDER_SHIFT to configure STACK_HASH_SIZE. >>> >>> Aim is to have configurable value for STACK_HASH_SIZE, >>> so

Re: [PATCH v4 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2021-01-18 Thread Vijayanand Jitta
On 1/7/2021 3:14 PM, Alexander Potapenko wrote: > On Wed, Dec 30, 2020 at 1:46 PM wrote: >> >> From: Yogesh Lal >> >> Use STACK_HASH_ORDER_SHIFT to configure STACK_HASH_SIZE. > I think "ORDER_SHIFT" is somewhat redundant, as "SMTH_ORDER" already > means this is a power of two we'll be using fo

Re: [PATCH v4 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2021-01-07 Thread Alexander Potapenko
On Wed, Dec 30, 2020 at 1:46 PM wrote: > > From: Yogesh Lal > > Use STACK_HASH_ORDER_SHIFT to configure STACK_HASH_SIZE. I think "ORDER_SHIFT" is somewhat redundant, as "SMTH_ORDER" already means this is a power of two we'll be using for shifting. Leaving this up to you. Alex

Re: [PATCH v4 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2021-01-05 Thread Vijayanand Jitta
On 1/5/2021 4:42 AM, Andrew Morton wrote: > On Wed, 30 Dec 2020 18:15:30 +0530 vji...@codeaurora.org wrote: > >> Use STACK_HASH_ORDER_SHIFT to configure STACK_HASH_SIZE. >> >> Aim is to have configurable value for STACK_HASH_SIZE, >> so depend on use case one can configure it. >> >> One exampl

Re: [PATCH v4 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2021-01-04 Thread Andrew Morton
On Wed, 30 Dec 2020 18:15:30 +0530 vji...@codeaurora.org wrote: > Use STACK_HASH_ORDER_SHIFT to configure STACK_HASH_SIZE. > > Aim is to have configurable value for STACK_HASH_SIZE, > so depend on use case one can configure it. > > One example is of Page Owner, default value of > STACK_HASH_SIZ

[PATCH v4 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-30 Thread vjitta
From: Yogesh Lal Use STACK_HASH_ORDER_SHIFT to configure STACK_HASH_SIZE. Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it. One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making i