Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-19 Thread Ivan Khoronzhuk
On 02/19/2014 04:34 PM, Greg KH wrote: On Wed, Feb 19, 2014 at 12:32:02PM +0200, Ivan Khoronzhuk wrote: + aemif->clk = devm_clk_get(dev, NULL); + if (IS_ERR(aemif->clk)) { + dev_err(dev, "cannot get clock 'aemif'\n"); + return PTR_ERR(aemif->clk); No

Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-19 Thread Greg KH
On Wed, Feb 19, 2014 at 12:32:02PM +0200, Ivan Khoronzhuk wrote: > >> + aemif->clk = devm_clk_get(dev, NULL); > >> + if (IS_ERR(aemif->clk)) { > >> + dev_err(dev, "cannot get clock 'aemif'\n"); > >> + return PTR_ERR(aemif->clk); > > No freeing memory? > > There is no need to

Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-19 Thread Ivan Khoronzhuk
On 02/18/2014 10:30 PM, Greg KH wrote: On Wed, Feb 05, 2014 at 09:46:13PM +0200, Ivan Khoronzhuk wrote: Add new AEMIF driver for EMIF16 Texas Instruments controller. The EMIF16 module is intended to provide a glue-less interface to a variety of asynchronous memory devices like ASRA M, NOR and

Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-19 Thread Ivan Khoronzhuk
On 02/18/2014 10:30 PM, Greg KH wrote: On Wed, Feb 05, 2014 at 09:46:13PM +0200, Ivan Khoronzhuk wrote: Add new AEMIF driver for EMIF16 Texas Instruments controller. The EMIF16 module is intended to provide a glue-less interface to a variety of asynchronous memory devices like ASRA M, NOR and

Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-19 Thread Greg KH
On Wed, Feb 19, 2014 at 12:32:02PM +0200, Ivan Khoronzhuk wrote: + aemif-clk = devm_clk_get(dev, NULL); + if (IS_ERR(aemif-clk)) { + dev_err(dev, cannot get clock 'aemif'\n); + return PTR_ERR(aemif-clk); No freeing memory? There is no need to free memory

Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-19 Thread Ivan Khoronzhuk
On 02/19/2014 04:34 PM, Greg KH wrote: On Wed, Feb 19, 2014 at 12:32:02PM +0200, Ivan Khoronzhuk wrote: + aemif-clk = devm_clk_get(dev, NULL); + if (IS_ERR(aemif-clk)) { + dev_err(dev, cannot get clock 'aemif'\n); + return PTR_ERR(aemif-clk); No freeing

Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-18 Thread Greg KH
On Wed, Feb 05, 2014 at 09:46:13PM +0200, Ivan Khoronzhuk wrote: > Add new AEMIF driver for EMIF16 Texas Instruments controller. > The EMIF16 module is intended to provide a glue-less interface to > a variety of asynchronous memory devices like ASRA M, NOR and NAND > memory. A total of 256M bytes

Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-18 Thread Greg KH
On Wed, Feb 05, 2014 at 09:46:13PM +0200, Ivan Khoronzhuk wrote: Add new AEMIF driver for EMIF16 Texas Instruments controller. The EMIF16 module is intended to provide a glue-less interface to a variety of asynchronous memory devices like ASRA M, NOR and NAND memory. A total of 256M bytes of

[PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-05 Thread Ivan Khoronzhuk
Add new AEMIF driver for EMIF16 Texas Instruments controller. The EMIF16 module is intended to provide a glue-less interface to a variety of asynchronous memory devices like ASRA M, NOR and NAND memory. A total of 256M bytes of any of these memories can be accessed at any given time via 4 chip

[PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver

2014-02-05 Thread Ivan Khoronzhuk
Add new AEMIF driver for EMIF16 Texas Instruments controller. The EMIF16 module is intended to provide a glue-less interface to a variety of asynchronous memory devices like ASRA M, NOR and NAND memory. A total of 256M bytes of any of these memories can be accessed at any given time via 4 chip