Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-11 Thread Andrew Morton
On Fri, 11 Apr 2025 17:08:33 -0400 Waiman Long wrote: > > - * A/B/F memory.current = 0 > > + * A/B/C memory.current ~= 29M, memory.events:low > 0 > > + * A/B/D memory.current ~= 21M, memory.events:low > 0 > > + * A/B/E memory.current ~= 0, memory.events:low not specified (==0 > > w/out me

Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-11 Thread Waiman Long
On 4/7/25 11:25 AM, Michal Koutný wrote: Hi Waiman. On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: ... diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index 16f5d74ae762..bab826b6b7b0 100644 --- a/tools/testing/

Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-07 Thread Michal Koutný
Hi Waiman. On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: ... > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c > b/tools/testing/selftests/cgroup/test_memcontrol.c > index 16f5d74ae762..bab826b6b7b0 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c >

Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-07 Thread Waiman Long
On 4/7/25 10:24 AM, Johannes Weiner wrote: On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: The test_memcontrol selftest consistently fails its test_memcg_low sub-test due to the fact that two of its test child cgroups which have a memmory.low of 0 or an effective memory.low of 0 sti

Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-07 Thread Johannes Weiner
On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: > The test_memcontrol selftest consistently fails its test_memcg_low > sub-test due to the fact that two of its test child cgroups which > have a memmory.low of 0 or an effective memory.low of 0 still have low > events generated for them

[PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs()

2025-04-06 Thread Waiman Long
The test_memcontrol selftest consistently fails its test_memcg_low sub-test due to the fact that two of its test child cgroups which have a memmory.low of 0 or an effective memory.low of 0 still have low events generated for them since mem_cgroup_below_low() use the ">=" operator when comparing to