Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-24 Thread Johan Hovold
On Mon, Nov 24, 2014 at 01:58:50PM +0100, Romain Perier wrote: > 2014-11-24 12:35 GMT+01:00 Johan Hovold : > > You should also fix the commit message, which claims to define a "helper > > function which is compatible with both properties", something which was > > no longer the case. > > > So I nee

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-24 Thread Heiko Stübner
Am Montag, 24. November 2014, 14:01:02 schrieb Romain Perier: > 2014-11-24 13:58 GMT+01:00 Romain Perier : > > So I need to resend this patch which would only introduce an helper > > function which checks for "system-power-controller" property (it would > > also have a new commit message). > > As y

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-24 Thread Romain Perier
2014-11-24 13:58 GMT+01:00 Romain Perier : > 2014-11-24 12:35 GMT+01:00 Johan Hovold : >> On Mon, Nov 24, 2014 at 10:24:56AM +, Lee Jones wrote: >>> On Fri, 21 Nov 2014, Johan Hovold wrote: >>> > On Thu, Nov 13, 2014 at 01:34:58PM +, Auto Configured wrote: >>> > > From: Romain Perier >>> >

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-24 Thread Romain Perier
2014-11-24 12:35 GMT+01:00 Johan Hovold : > On Mon, Nov 24, 2014 at 10:24:56AM +, Lee Jones wrote: >> On Fri, 21 Nov 2014, Johan Hovold wrote: >> > On Thu, Nov 13, 2014 at 01:34:58PM +, Auto Configured wrote: >> > > From: Romain Perier >> > > >> > > It reverts commit a4b4e0461ec5 ("of: Add

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-24 Thread Johan Hovold
On Mon, Nov 24, 2014 at 10:24:56AM +, Lee Jones wrote: > On Fri, 21 Nov 2014, Johan Hovold wrote: > > On Thu, Nov 13, 2014 at 01:34:58PM +, Auto Configured wrote: > > > From: Romain Perier > > > > > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff > > > capabilit

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-24 Thread Lee Jones
On Fri, 21 Nov 2014, Johan Hovold wrote: > On Thu, Nov 13, 2014 at 01:34:58PM +, Auto Configured wrote: > > From: Romain Perier > > > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff > > capability"). > > As discussed on the mailing list, it makes more sense to rena

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-21 Thread Romain Perier
2014-11-21 14:18 GMT+01:00 Romain Perier : > it was merged by Lee Jones (so it was merged onto > the mfd tree) It was done, for a previous serie, not this one . This is when I proposed to update the dts too (for all boards using the custom property) until the discussion turned into a troll. Rom

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-21 Thread Romain Perier
2014-11-21 11:59 GMT+01:00 Johan Hovold : > On Thu, Nov 13, 2014 at 01:34:58PM +, Auto Configured wrote: >> From: Romain Perier >> >> It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff >> capability"). >> As discussed on the mailing list, it makes more sense to rename bac

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-21 Thread Johan Hovold
On Thu, Nov 13, 2014 at 01:34:58PM +, Auto Configured wrote: > From: Romain Perier > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff > capability"). > As discussed on the mailing list, it makes more sense to rename back to the > old established property name, withou

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-20 Thread Romain Perier
ping 2014-11-17 11:51 GMT+01:00 Romain Perier : > @Most of the people who were ranting about this serie: could you send > feedbacks please ? > > 2014-11-14 8:22 GMT+01:00 Romain Perier : >> Hi, >> >> Who should merge this serie ? as Mark merged the previous one it would >> probably make sense to

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-17 Thread Romain Perier
@Most of the people who were ranting about this serie: could you send feedbacks please ? 2014-11-14 8:22 GMT+01:00 Romain Perier : > Hi, > > Who should merge this serie ? as Mark merged the previous one it would > probably make sense to do the same here (at least, in my opinion) > > Thanks for yo

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-13 Thread Romain Perier
Hi, Who should merge this serie ? as Mark merged the previous one it would probably make sense to do the same here (at least, in my opinion) Thanks for your feedbacks. Have a nice day, Romain 2014-11-13 21:55 GMT+01:00 Grant Likely : igned-off-by: Romain Perier > > Acked-by: Grant Likely > >

Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-13 Thread Grant Likely
On Thu, 13 Nov 2014 13:34:58 + , Auto Configured wrote: > From: Romain Perier > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff > capability"). > As discussed on the mailing list, it makes more sense to rename back to the > old established property name, without t

[PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-13 Thread Auto Configured
From: Romain Perier It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability"). As discussed on the mailing list, it makes more sense to rename back to the old established property name, without the vendor prefix. Problem being that the word "source" usually tends to be