RE: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-23 Thread Yuan, Perry
ciello, Mario > Cc: linux-kernel@vger.kernel.org; alsa-de...@alsa-project.org; > broo...@kernel.org; lgirdw...@gmail.com; platform-driver- > x...@vger.kernel.org > Subject: Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell > hardware privacy > > > [EXTERNAL EMAI

Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-22 Thread Pierre-Louis Bossart
As you suggested,I should add the alignment change in another patch. But if i keep the old alignment, the code will be very odd. Seems like that I have to change the below code to new alignment in this patch. if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&    

Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-21 Thread Perry Yuan
Hi Pierre: Thanks for your review! On 2021/3/8 23:59, Pierre-Louis Bossart wrote:    module_param(force_rfkill, bool, 0444);    MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted models"); + spurious line change I just want to make them separate with more space . If it

Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-08 Thread Pierre-Louis Bossart
module_param(force_rfkill, bool, 0444); MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted models"); + spurious line change I just want to make them separate with more space . If it cause concern, I will remote the line in V5. it's fine to improve spaces/alignment,

RE: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-08 Thread Yuan, Perry
Mario > Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-project.org; > linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org > Subject: Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell > hardware privacy > > > [EXTERNAL EMAIL] > > &

Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-01 Thread Randy Dunlap
On 3/1/21 1:37 AM, Perry Yuan wrote: > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 91e6176cdfbd..e20f79389a39 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -491,6 +491,23 @@ config DELL_WMI_LED > This adds support

Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-01 Thread Pierre-Louis Bossart
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index 581475f59819..18c430456de7 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -51,7 +51,9 @@ obj-$(CONFIG_DELL_WMI_DESCRIPTOR) += dell-wmi-descriptor.o

[PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-01 Thread Perry Yuan
From: Perry Yuan add support for Dell privacy driver for the Dell units equipped hardware privacy design, which protect users privacy of audio and camera from hardware level. Once the audio or camera privacy mode activated, any applications will not get any audio or video stream when user