Re: [PATCH v4 1/2] rust: add static_key_false

2024-08-01 Thread Alice Ryhl
On Thu, Aug 1, 2024 at 12:28 PM Peter Zijlstra wrote: > > On Wed, Jul 31, 2024 at 11:34:13PM +0200, Alice Ryhl wrote: > > > > Please work harder to not have to duplicate stuff like this. > > > > I really didn't want to duplicate it, but it's very hard to find a > > performant alternative. Is

Re: [PATCH v4 1/2] rust: add static_key_false

2024-08-01 Thread Peter Zijlstra
On Wed, Jul 31, 2024 at 11:34:13PM +0200, Alice Ryhl wrote: > > Please work harder to not have to duplicate stuff like this. > > I really didn't want to duplicate it, but it's very hard to find a > performant alternative. Is there any way we could accept duplication > only in the cases where an

Re: [PATCH v4 1/2] rust: add static_key_false

2024-07-31 Thread Alice Ryhl
On Wed, Jul 31, 2024 at 7:05 PM Peter Zijlstra wrote: > > On Fri, Jun 28, 2024 at 01:23:31PM +, Alice Ryhl wrote: > > > rust/kernel/arch/arm64/jump_label.rs | 34 > > rust/kernel/arch/loongarch/jump_label.rs | 35 + > >

Re: [PATCH v4 1/2] rust: add static_key_false

2024-07-31 Thread Peter Zijlstra
On Fri, Jun 28, 2024 at 01:23:31PM +, Alice Ryhl wrote: > rust/kernel/arch/arm64/jump_label.rs | 34 > rust/kernel/arch/loongarch/jump_label.rs | 35 + > rust/kernel/arch/mod.rs | 24 >

Re: [PATCH v4 1/2] rust: add static_key_false

2024-07-30 Thread Gary Guo
On Fri, 28 Jun 2024 13:23:31 + Alice Ryhl wrote: > Add just enough support for static key so that we can use it from > tracepoints. Tracepoints rely on `static_key_false` even though it is > deprecated, so we add the same functionality to Rust. > > It is not possible to use the existing C

Re: [PATCH v4 1/2] rust: add static_key_false

2024-06-30 Thread hev
Hi Alice On Fri, Jun 28, 2024 at 9:24 PM Alice Ryhl wrote: > > Add just enough support for static key so that we can use it from > tracepoints. Tracepoints rely on `static_key_false` even though it is > deprecated, so we add the same functionality to Rust. > > It is not possible to use the

[PATCH v4 1/2] rust: add static_key_false

2024-06-28 Thread Alice Ryhl
Add just enough support for static key so that we can use it from tracepoints. Tracepoints rely on `static_key_false` even though it is deprecated, so we add the same functionality to Rust. It is not possible to use the existing C implementation of arch_static_branch because it passes the