Re: [PATCH v4 1/2] spi: Add MXIC controller driver

On Mon, Oct 08, 2018 at 10:38:12AM +0200, Boris Brezillon wrote: > This is wrong, ->cur_speed_hz should be updated in > mxic_prepare_transfer_hardware() or mxic_spi_clk_check(), not when > ->setup() is called. Also, you seem to ignore the xfer->speed_hz value, > which might be different from spi->

Re: [PATCH v4 1/2] spi: Add MXIC controller driver

Hi Mason, On Mon, 8 Oct 2018 10:25:31 +0800 masonccy...@mxic.com.tw wrote: > +static int mxic_spi_clk_enable(struct mxic_spi *mxic) > +{ > + int ret; > + > + ret = clk_prepare_enable(mxic->send_clk); > + if (ret) > + goto out; Please don't use gotos when it's not necessa

[PATCH v4 1/2] spi: Add MXIC controller driver

From: Mason Yang Add a driver for Macronix SPI controller IP. Signed-off-by: Mason Yang --- drivers/spi/Kconfig| 6 + drivers/spi/Makefile | 1 + drivers/spi/spi-mxic.c | 639 + 3 files changed, 646 insertions(+) create mode 100644 dri