Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-12 Thread Jarkko Sakkinen
On Mon, Feb 11, 2019 at 04:05:39PM +0100, Alexander Steffen wrote: > Tested-by: Alexander Steffen Thank you! /Jarkko

Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-11 Thread Alexander Steffen
On 08.02.2019 20:00, Jarkko Sakkinen wrote: On Fri, Feb 08, 2019 at 01:12:34PM -0500, Stefan Berger wrote: On 2/8/19 1:08 PM, Jarkko Sakkinen wrote: The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main tran

Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-11 Thread Jarkko Sakkinen
On Sat, Feb 09, 2019 at 11:20:22AM -0700, Jerry Snitselaar wrote: > Does st33zp24_i2c_send need an update as well? It does 'return > write8_reg()'. After these commits the only situation when st33zp24_i2c_send() return value is returned back to the user space, when called from st33zp24_send(), is

Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-09 Thread Jerry Snitselaar
On Sat, Feb 9, 2019 at 11:20 AM Jerry Snitselaar wrote: > > On Fri Feb 08 19, Jarkko Sakkinen wrote: > >The send() callback should never return length as it does not in every > >driver except tpm_crb in the success case. The reason is that the main > >transmit functionality only cares about whethe

Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-09 Thread Jerry Snitselaar
On Fri Feb 08 19, Jarkko Sakkinen wrote: The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main transmit functionality only cares about whether the transmit was successful or not and ignores the count completel

Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Jarkko Sakkinen
On Fri, Feb 08, 2019 at 01:12:34PM -0500, Stefan Berger wrote: > On 2/8/19 1:08 PM, Jarkko Sakkinen wrote: > > The send() callback should never return length as it does not in every > > driver except tpm_crb in the success case. The reason is that the main > > transmit functionality only cares abou

Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Stefan Berger
On 2/8/19 1:08 PM, Jarkko Sakkinen wrote: The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main transmit functionality only cares about whether the transmit was successful or not and ignores the count complete

[PATCH v4 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Jarkko Sakkinen
The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main transmit functionality only cares about whether the transmit was successful or not and ignores the count completely. Cc: sta...@vger.kernel.org Signed-off-b