Re: [PATCH v4 1/2] usbip: Fix-format-overflow

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 09:04:54AM -0600, Shuah Khan wrote: > On 02/27/2017 01:31 AM, Jonathan Dieter wrote: > > The usbip userspace tools call sprintf()/snprintf() and don't check for > > the return value which can lead the paths to overflow, truncating the > > final file in the path. > > > > Mor

Re: [PATCH v4 1/2] usbip: Fix-format-overflow

2017-03-16 Thread Shuah Khan
On 02/27/2017 01:31 AM, Jonathan Dieter wrote: > The usbip userspace tools call sprintf()/snprintf() and don't check for > the return value which can lead the paths to overflow, truncating the > final file in the path. > > More urgently, GCC 7 now warns that these aren't checked with > -Wformat-ov

Re: [PATCH v4 1/2] usbip: Fix-format-overflow

2017-03-16 Thread Jonathan Dieter
On Mon, 2017-02-27 at 10:31 +0200, Jonathan Dieter wrote: > The usbip userspace tools call sprintf()/snprintf() and don't check for > the return value which can lead the paths to overflow, truncating the > final file in the path. > > More urgently, GCC 7 now warns that these aren't checked with >

[PATCH v4 1/2] usbip: Fix-format-overflow

2017-02-27 Thread Jonathan Dieter
The usbip userspace tools call sprintf()/snprintf() and don't check for the return value which can lead the paths to overflow, truncating the final file in the path. More urgently, GCC 7 now warns that these aren't checked with -Wformat-overflow, and with -Werror enabled in configure.ac, that make