Re: [PATCH v4 1/3] ARM: rockchip: fix the CPU soft reset

2015-06-07 Thread Heiko Stübner
Hi Caesar, Doug, Am Sonntag, 7. Juni 2015, 13:51:24 schrieb Caesar Wang: > 在 2015年06月07日 11:43, Doug Anderson 写道: > > Caesar, > > > > On Sat, Jun 6, 2015 at 7:51 PM, Caesar Wang wrote: > >> @@ -150,13 +159,15 @@ static int __cpuinit > >> rockchip_boot_secondary(unsigned > >> int cpu, > >> > >>

Re: [PATCH v4 1/3] ARM: rockchip: fix the CPU soft reset

2015-06-06 Thread Caesar Wang
在 2015年06月07日 11:43, Doug Anderson 写道: Caesar, On Sat, Jun 6, 2015 at 7:51 PM, Caesar Wang wrote: @@ -150,13 +159,15 @@ static int __cpuinit rockchip_boot_secondary(unsigned int cpu, * sram_base_addr + 4: 0xdeadbeaf * sram_base_addr + 8: start address for

Re: [PATCH v4 1/3] ARM: rockchip: fix the CPU soft reset

2015-06-06 Thread Doug Anderson
Caesar, On Sat, Jun 6, 2015 at 7:51 PM, Caesar Wang wrote: > @@ -150,13 +159,15 @@ static int __cpuinit rockchip_boot_secondary(unsigned > int cpu, > * sram_base_addr + 4: 0xdeadbeaf > * sram_base_addr + 8: start address for pc > * */ > -

Re: [PATCH v4 1/3] ARM: rockchip: fix the CPU soft reset

2015-06-06 Thread Caesar Wang
在 2015年06月06日 04:55, Doug Anderson 写道: Caesar, On Fri, Jun 5, 2015 at 10:05 AM, Caesar Wang wrote: + if (!on) + reset_control_assert(rstc); + + ret = regmap_update_bits(pmu, PMU_PWRDN_CON, BIT(pd), val); + if (ret < 0) { +

Re: [PATCH v4 1/3] ARM: rockchip: fix the CPU soft reset

2015-06-05 Thread Doug Anderson
Caesar, On Fri, Jun 5, 2015 at 10:05 AM, Caesar Wang wrote: > + if (!on) > + reset_control_assert(rstc); > + > + ret = regmap_update_bits(pmu, PMU_PWRDN_CON, BIT(pd), val); > + if (ret < 0) { > + pr_err("%s: cou

[PATCH v4 1/3] ARM: rockchip: fix the CPU soft reset

2015-06-05 Thread Caesar Wang
We need different orderings when turning a core on and turning a core off. In one case we need to assert reset before turning power off. In ther other case we need to turn power on and the deassert reset. In general, the correct flow is: CPU off: reset_control_assert regmap_update_bits(p

[PATCH v4 1/3] ARM: rockchip: fix the CPU soft reset

2015-06-05 Thread Caesar Wang
We need different orderings when turning a core on and turning a core off. In one case we need to assert reset before turning power off. In ther other case we need to turn power on and the deassert reset. In general, the correct flow is: CPU off: reset_control_assert regmap_update_bits(p