Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-30 Thread Masahiro Yamada
Hi Andrew, On Sat, Nov 24, 2018 at 6:06 PM Miguel Ojeda wrote: > > On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck > wrote: > > > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > > reported

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-30 Thread Masahiro Yamada
Hi Andrew, On Sat, Nov 24, 2018 at 6:06 PM Miguel Ojeda wrote: > > On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck > wrote: > > > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > > reported

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-25 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 6:06 PM Miguel Ojeda wrote: > > On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck > wrote: > > > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > > reported lots of

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-25 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 6:06 PM Miguel Ojeda wrote: > > On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck > wrote: > > > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > > reported lots of

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-24 Thread Miguel Ojeda
On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck wrote: > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > reported lots of "unknown expression" warnings from container_of(), > > which seemed false

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-24 Thread Miguel Ojeda
On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck wrote: > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > reported lots of "unknown expression" warnings from container_of(), > > which seemed false

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-22 Thread Luc Van Oostenryck
On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > reported lots of "unknown expression" warnings from container_of(), > which seemed false positive. > > I addressed this in [1], but fixing Sparse is the right

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-22 Thread Luc Van Oostenryck
On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > reported lots of "unknown expression" warnings from container_of(), > which seemed false positive. > > I addressed this in [1], but fixing Sparse is the right

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-21 Thread Andrew Morton
On Thu, 22 Nov 2018 12:14:20 +0900 Masahiro Yamada wrote: > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > reported lots of "unknown expression" warnings from container_of(), > which seemed false positive. > > I addressed this in [1], but fixing Sparse is the right

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-21 Thread Andrew Morton
On Thu, 22 Nov 2018 12:14:20 +0900 Masahiro Yamada wrote: > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > reported lots of "unknown expression" warnings from container_of(), > which seemed false positive. > > I addressed this in [1], but fixing Sparse is the right

[PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-21 Thread Masahiro Yamada
When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot reported lots of "unknown expression" warnings from container_of(), which seemed false positive. I addressed this in [1], but fixing Sparse is the right thing to do. The issue was fixed by Sparse commit 0eb8175d3e9c ("fix

[PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-21 Thread Masahiro Yamada
When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot reported lots of "unknown expression" warnings from container_of(), which seemed false positive. I addressed this in [1], but fixing Sparse is the right thing to do. The issue was fixed by Sparse commit 0eb8175d3e9c ("fix