Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-24 Thread Jean-Jacques Hiblot
On 23/09/2019 23:03, Jacek Anaszewski wrote: Hi Jean, On 9/23/19 11:14 AM, Jean-Jacques Hiblot wrote: Hi Jacek, On 20/09/2019 23:10, Jacek Anaszewski wrote: Hi Jean, On 9/20/19 2:25 PM, Jean-Jacques Hiblot wrote: Making led_set_brightness_sync() use led_set_brightness_nosleep() has 2

Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-23 Thread Jacek Anaszewski
Hi Jean, On 9/23/19 11:14 AM, Jean-Jacques Hiblot wrote: > Hi Jacek, > > On 20/09/2019 23:10, Jacek Anaszewski wrote: >> Hi Jean, >> >> On 9/20/19 2:25 PM, Jean-Jacques Hiblot wrote: >>> Making led_set_brightness_sync() use led_set_brightness_nosleep() has 2 >>> advantages: >>> - works for LED

Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-23 Thread Jean-Jacques Hiblot
Hi Jacek, On 20/09/2019 23:10, Jacek Anaszewski wrote: Hi Jean, On 9/20/19 2:25 PM, Jean-Jacques Hiblot wrote: Making led_set_brightness_sync() use led_set_brightness_nosleep() has 2 advantages: - works for LED controllers that do not provide brightness_set_blocking() - When the blocking

Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-21 Thread kbuild test robot
Hi Jean-Jacques, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190919] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to

Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-20 Thread Jacek Anaszewski
Hi Jean, On 9/20/19 2:25 PM, Jean-Jacques Hiblot wrote: > Making led_set_brightness_sync() use led_set_brightness_nosleep() has 2 > advantages: > - works for LED controllers that do not provide brightness_set_blocking() > - When the blocking callback is used, it uses the workqueue to update the >

[PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-20 Thread Jean-Jacques Hiblot
Making led_set_brightness_sync() use led_set_brightness_nosleep() has 2 advantages: - works for LED controllers that do not provide brightness_set_blocking() - When the blocking callback is used, it uses the workqueue to update the LED state, removing the need for mutual exclusion between