Re: [PATCH v4 1/3] leds: Require valid fwnode pointer for composing name

2020-09-15 Thread Jacek Anaszewski
Hi Alexander, On 9/15/20 11:14 AM, Alexander Dahl wrote: Hello Jacek, thanks for your feedback. See below. Am Freitag, 11. September 2020, 23:26:43 CEST schrieb Jacek Anaszewski: On 9/11/20 5:40 PM, Alexander Dahl wrote: The function 'led_compose_name()' is called in

Re: [PATCH v4 1/3] leds: Require valid fwnode pointer for composing name

2020-09-15 Thread Alexander Dahl
Hello Jacek, thanks for your feedback. See below. Am Freitag, 11. September 2020, 23:26:43 CEST schrieb Jacek Anaszewski: > On 9/11/20 5:40 PM, Alexander Dahl wrote: > > The function 'led_compose_name()' is called in > > 'led_classdev_register_ext(()' only and in its implementation it always > >

Re: [PATCH v4 1/3] leds: Require valid fwnode pointer for composing name

2020-09-11 Thread Jacek Anaszewski
Hi Alexander, On 9/11/20 5:40 PM, Alexander Dahl wrote: The function 'led_compose_name()' is called in 'led_classdev_register_ext(()' only and in its implementation it always parses the fwnode passed with the init_data struct. If there's no fwnode, EINVAL is returned and

[PATCH v4 1/3] leds: Require valid fwnode pointer for composing name

2020-09-11 Thread Alexander Dahl
The function 'led_compose_name()' is called in 'led_classdev_register_ext(()' only and in its implementation it always parses the fwnode passed with the init_data struct. If there's no fwnode, EINVAL is returned and 'led_classdev_register_ext()' returns early. If this is detected early the same