Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Alim, On Tue, Feb 24, 2015 at 11:52 PM, Alim Akhtar wrote: >>> This looks a HACK to me. >>> If stabilizing host voltage regulator is the problem, can you try out >>> below patch, and see if this resolve your issue? >> >> Actually, IMHO Alim's patch is more of a hack than Addy's. There's >>

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi, On 02/25/2015 04:52 PM, Alim Akhtar wrote: > Hi Doug, > > > On Fri, Feb 20, 2015 at 5:19 AM, Doug Anderson wrote: >> Alim and Addy, >> >> On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar wrote: >>> Hi Addy, >>> >>> On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke wrote: As show in

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Alim, On Tue, Feb 24, 2015 at 11:52 PM, Alim Akhtar alim.akh...@gmail.com wrote: This looks a HACK to me. If stabilizing host voltage regulator is the problem, can you try out below patch, and see if this resolve your issue? Actually, IMHO Alim's patch is more of a hack than Addy's. There's

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi, On 02/25/2015 04:52 PM, Alim Akhtar wrote: Hi Doug, On Fri, Feb 20, 2015 at 5:19 AM, Doug Anderson diand...@chromium.org wrote: Alim and Addy, On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Addy, On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi Doug, On Fri, Feb 20, 2015 at 5:19 AM, Doug Anderson wrote: > Alim and Addy, > > On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar wrote: >> Hi Addy, >> >> On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke wrote: >>> As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't >>> stable and we

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi Doug, On Fri, Feb 20, 2015 at 5:19 AM, Doug Anderson diand...@chromium.org wrote: Alim and Addy, On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Addy, On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke addy...@rock-chips.com wrote: As show in mmc_power_up(), in

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi, On Thu, Feb 19, 2015 at 5:04 PM, Doug Anderson wrote: > Hi, > > On Thu, Feb 19, 2015 at 3:49 PM, Doug Anderson wrote: >> I've got that coded up but I'm still testing it... If you want to try >> it too, you can find it at >> . >> >> Note that

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi, On Thu, Feb 19, 2015 at 5:04 PM, Doug Anderson diand...@chromium.org wrote: Hi, On Thu, Feb 19, 2015 at 3:49 PM, Doug Anderson diand...@chromium.org wrote: I've got that coded up but I'm still testing it... If you want to try it too, you can find it at

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi, On Thu, Feb 19, 2015 at 3:49 PM, Doug Anderson wrote: > I've got that coded up but I'm still testing it... If you want to try > it too, you can find it at > . > > Note that without my patch I find that I _really_ need Addy's patch to > make

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

On Thu, Feb 19, 2015 at 03:49:46PM -0800, Doug Anderson wrote: > Alim and Addy, > > On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar wrote: > > Hi Addy, > > > > On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke wrote: > >> As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't > >> stable and

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Alim and Addy, On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar wrote: > Hi Addy, > > On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke wrote: >> As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't >> stable and we may get 'data busy' which can't be cleaned by resetting >> all blocks. So we

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi, Alim Sorry for late reply. On 2015/2/16 07:28, Alim Akhtar wrote: > Hi Addy, > > On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke wrote: >> As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't >> stable and we may get 'data busy' which can't be cleaned by resetting >> all blocks.

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi, Alim Sorry for late reply. On 2015/2/16 07:28, Alim Akhtar wrote: Hi Addy, On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke addy...@rock-chips.com wrote: As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't stable and we may get 'data busy' which can't be cleaned by resetting

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi, On Thu, Feb 19, 2015 at 3:49 PM, Doug Anderson diand...@chromium.org wrote: I've got that coded up but I'm still testing it... If you want to try it too, you can find it at https://chromium-review.googlesource.com/251341. Note that without my patch I find that I _really_ need Addy's

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Alim and Addy, On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Addy, On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke addy...@rock-chips.com wrote: As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't stable and we may get 'data busy' which can't be

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

On Thu, Feb 19, 2015 at 03:49:46PM -0800, Doug Anderson wrote: Alim and Addy, On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Addy, On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke addy...@rock-chips.com wrote: As show in mmc_power_up(), in MMC_POWER_UP state, the

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi Addy, On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke wrote: > As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't > stable and we may get 'data busy' which can't be cleaned by resetting > all blocks. So we should not send command to update clock in this state. > > Signed-off-by:

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

Hi Addy, On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke addy...@rock-chips.com wrote: As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't stable and we may get 'data busy' which can't be cleaned by resetting all blocks. So we should not send command to update clock in this state.

[PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't stable and we may get 'data busy' which can't be cleaned by resetting all blocks. So we should not send command to update clock in this state. Signed-off-by: Addy Ke --- drivers/mmc/host/dw_mmc.c | 3 ++- 1 file changed, 2

[PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

As show in mmc_power_up(), in MMC_POWER_UP state, the voltage isn't stable and we may get 'data busy' which can't be cleaned by resetting all blocks. So we should not send command to update clock in this state. Signed-off-by: Addy Ke addy...@rock-chips.com --- drivers/mmc/host/dw_mmc.c | 3 ++-