Re: [PATCH v4 1/4] HID: i2c-hid: Reorganize so ACPI and OF are subclasses

Hi, On Mon, Nov 9, 2020 at 6:44 AM Hans de Goede wrote: > > Hi, > > On 11/9/20 3:29 PM, Benjamin Tissoires wrote: > > Hi, > > > > sorry for the delay. I have been heavily sidetracked and have a bunch > > of internal deadlines coming in :/ > > > > On Mon, Nov 9, 2020 at 12:24 PM Hans de Goede wro

Re: [PATCH v4 1/4] HID: i2c-hid: Reorganize so ACPI and OF are subclasses

Hi, On 11/9/20 3:29 PM, Benjamin Tissoires wrote: > Hi, > > sorry for the delay. I have been heavily sidetracked and have a bunch > of internal deadlines coming in :/ > > On Mon, Nov 9, 2020 at 12:24 PM Hans de Goede wrote: >> >> Hi, >> >> On 11/4/20 5:06 PM, Doug Anderson wrote: >>> Hi, >>> >>

Re: [PATCH v4 1/4] HID: i2c-hid: Reorganize so ACPI and OF are subclasses

Hi, sorry for the delay. I have been heavily sidetracked and have a bunch of internal deadlines coming in :/ On Mon, Nov 9, 2020 at 12:24 PM Hans de Goede wrote: > > Hi, > > On 11/4/20 5:06 PM, Doug Anderson wrote: > > Hi, > > > > On Wed, Nov 4, 2020 at 4:07 AM Hans de Goede wrote: > >> > >>> +

Re: [PATCH v4 1/4] HID: i2c-hid: Reorganize so ACPI and OF are subclasses

Hi, On 11/4/20 5:06 PM, Doug Anderson wrote: > Hi, > > On Wed, Nov 4, 2020 at 4:07 AM Hans de Goede wrote: >> >>> +#include "i2c-hid.h" >>> + >>> +struct i2c_hid_acpi { >>> + struct i2chid_subclass_data subclass; >> >> This feels a bit weird, we are the subclass so typically we would >> be e

Re: [PATCH v4 1/4] HID: i2c-hid: Reorganize so ACPI and OF are subclasses

Hi, On Wed, Nov 4, 2020 at 4:07 AM Hans de Goede wrote: > > > +#include "i2c-hid.h" > > + > > +struct i2c_hid_acpi { > > + struct i2chid_subclass_data subclass; > > This feels a bit weird, we are the subclass so typically we would > be embedding a base_class data struct here ... > > (more rem

Re: [PATCH v4 1/4] HID: i2c-hid: Reorganize so ACPI and OF are subclasses

Hi, On 11/4/20 2:29 AM, Douglas Anderson wrote: > This patch rejiggers the i2c-hid code so that the OF (Device Tree) and > ACPI support is separated out a bit. The OF and ACPI drivers are now > effectively "subclasses" of the generic code. > > Essentially, what we're doing here: > * Make "power

[PATCH v4 1/4] HID: i2c-hid: Reorganize so ACPI and OF are subclasses

This patch rejiggers the i2c-hid code so that the OF (Device Tree) and ACPI support is separated out a bit. The OF and ACPI drivers are now effectively "subclasses" of the generic code. Essentially, what we're doing here: * Make "power up" and "power down" a virtual function that can be (option