Re: [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-22 Thread Steven Rostedt
On Wed, 22 May 2019 16:35:45 +0200 Peter Zijlstra wrote: > > @@ -284,6 +285,7 @@ static void do_idle(void) > > smp_mb__after_atomic(); > > > > sched_ttwu_pending(); > > + /* schedule_idle() will call trace_enable_fsnotify() */ > > schedule_idle(); > > > > if

Re: [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-22 Thread Peter Zijlstra
On Wed, May 22, 2019 at 02:30:14AM +0200, Viktor Rosendahl wrote: > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 874c427742a9..440cd1a62722 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -3374,6 +3374,7 @@ static void __sched notrace __schedule(bool preempt)

Re: [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-22 Thread Peter Zijlstra
On Tue, May 21, 2019 at 12:01:42PM -0400, Steven Rostedt wrote: > > [ Added Peter and Rafael ] Thanks Steve, > On Fri, 17 May 2019 22:34:27 +0200 > Viktor Rosendahl wrote: > > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h > > index c8c7c7efb487..a1a1befea1c1 100644

Re: [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-21 Thread Steven Rostedt
On Wed, 22 May 2019 02:30:14 +0200 Viktor Rosendahl wrote: > > I can try to add the static branch if you want it though. Yes, it would need a static branch to prevent overhead. > > best regards, > > Viktor > --- > include/linux/ftrace.h | 13 + > kernel/sched/core.c| 2 +

Re: [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-21 Thread Viktor Rosendahl
On 5/21/19 6:01 PM, Steven Rostedt wrote:> > > Note, you need to add the scheduling and power management maintainers > when adding trace events to their code. > My bad. > As these trace events become visible to user space, and you only need a > callback to disable fsnotify, it may be better to

Re: [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-21 Thread Steven Rostedt
[ Added Peter and Rafael ] On Fri, 17 May 2019 22:34:27 +0200 Viktor Rosendahl wrote: > This patch implements the feature that the tracing_max_latency file, > e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive > notifications through the fsnotify framework when a new latency is >

[PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-17 Thread Viktor Rosendahl
This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications through the fsnotify framework when a new latency is available. One particularly interesting use of this facility is when enabling threshold tracing,