Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

On Thu, Mar 23, 2017 at 11:59 AM, John Keeping wrote: > regmap_update_bits does its own locking and everything else accessed > here is a local variable so there is no need to lock around it. > > Signed-off-by: John Keeping > Reviewed-by: Heiko Stuebner

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

On Thu, Mar 23, 2017 at 11:59 AM, John Keeping wrote: > regmap_update_bits does its own locking and everything else accessed > here is a local variable so there is no need to lock around it. > > Signed-off-by: John Keeping > Reviewed-by: Heiko Stuebner > Tested-by: Heiko Stuebner > --- > v3:

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

On Thu, Mar 23, 2017 at 09:01:43PM +0100, Heiko St?bner wrote: > Am Donnerstag, 23. März 2017, 13:29:10 CET schrieb Julia Cartwright: > > On Thu, Mar 23, 2017 at 06:55:50PM +0100, Heiko St?bner wrote: > > > Am Donnerstag, 23. März 2017, 17:51:53 CET schrieb John Keeping: > > > > On Thu, 23 Mar

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

On Thu, Mar 23, 2017 at 09:01:43PM +0100, Heiko St?bner wrote: > Am Donnerstag, 23. März 2017, 13:29:10 CET schrieb Julia Cartwright: > > On Thu, Mar 23, 2017 at 06:55:50PM +0100, Heiko St?bner wrote: > > > Am Donnerstag, 23. März 2017, 17:51:53 CET schrieb John Keeping: > > > > On Thu, 23 Mar

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

Am Donnerstag, 23. März 2017, 13:29:10 CET schrieb Julia Cartwright: > On Thu, Mar 23, 2017 at 06:55:50PM +0100, Heiko St?bner wrote: > > Am Donnerstag, 23. März 2017, 17:51:53 CET schrieb John Keeping: > > > On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote: > [..] > > > > > [..] > > >

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

Am Donnerstag, 23. März 2017, 13:29:10 CET schrieb Julia Cartwright: > On Thu, Mar 23, 2017 at 06:55:50PM +0100, Heiko St?bner wrote: > > Am Donnerstag, 23. März 2017, 17:51:53 CET schrieb John Keeping: > > > On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote: > [..] > > > > > [..] > > >

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

On Thu, Mar 23, 2017 at 06:55:50PM +0100, Heiko St?bner wrote: > Am Donnerstag, 23. März 2017, 17:51:53 CET schrieb John Keeping: > > On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote: [..] > > > [..] > > > > > > > @@ -1185,17 +1177,14 @@ static int rockchip_set_drive_perpin(struct > > >

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

On Thu, Mar 23, 2017 at 06:55:50PM +0100, Heiko St?bner wrote: > Am Donnerstag, 23. März 2017, 17:51:53 CET schrieb John Keeping: > > On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote: [..] > > > [..] > > > > > > > @@ -1185,17 +1177,14 @@ static int rockchip_set_drive_perpin(struct > > >

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

Am Donnerstag, 23. März 2017, 17:51:53 CET schrieb John Keeping: > On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote: > > One quick question below. Apologies if this has been covered, but just > > want to be sure. > > > > On Thu, Mar 23, 2017 at 10:59:28AM +, John Keeping wrote: > >

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

Am Donnerstag, 23. März 2017, 17:51:53 CET schrieb John Keeping: > On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote: > > One quick question below. Apologies if this has been covered, but just > > want to be sure. > > > > On Thu, Mar 23, 2017 at 10:59:28AM +, John Keeping wrote: > >

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote: > One quick question below. Apologies if this has been covered, but just > want to be sure. > > On Thu, Mar 23, 2017 at 10:59:28AM +, John Keeping wrote: > > regmap_update_bits does its own locking and everything else accessed > >

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote: > One quick question below. Apologies if this has been covered, but just > want to be sure. > > On Thu, Mar 23, 2017 at 10:59:28AM +, John Keeping wrote: > > regmap_update_bits does its own locking and everything else accessed > >

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

Hello John- One quick question below. Apologies if this has been covered, but just want to be sure. On Thu, Mar 23, 2017 at 10:59:28AM +, John Keeping wrote: > regmap_update_bits does its own locking and everything else accessed > here is a local variable so there is no need to lock around

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

Hello John- One quick question below. Apologies if this has been covered, but just want to be sure. On Thu, Mar 23, 2017 at 10:59:28AM +, John Keeping wrote: > regmap_update_bits does its own locking and everything else accessed > here is a local variable so there is no need to lock around

[PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

regmap_update_bits does its own locking and everything else accessed here is a local variable so there is no need to lock around it. Signed-off-by: John Keeping Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner --- v3: unchanged v2.1: -

[PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

regmap_update_bits does its own locking and everything else accessed here is a local variable so there is no need to lock around it. Signed-off-by: John Keeping Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner --- v3: unchanged v2.1: - Remove RK2928 locking in rockchip_set_pull() v2: -