Re: [PATCH v4 1/5] KVM: MMU: fix release noslot pfn

2012-10-14 Thread Marcelo Tosatti
On Fri, Oct 12, 2012 at 05:49:30PM +0800, Xiao Guangrong wrote: > On 10/11/2012 10:31 PM, Marcelo Tosatti wrote: > > On Thu, Oct 11, 2012 at 09:06:12PM +0800, Xiao Guangrong wrote: > >> On 10/10/2012 11:11 PM, Marcelo Tosatti wrote: > >> > >>> > >>> Why does is_error_pfn() return true for mmio spte

Re: [PATCH v4 1/5] KVM: MMU: fix release noslot pfn

2012-10-12 Thread Xiao Guangrong
On 10/11/2012 10:31 PM, Marcelo Tosatti wrote: > On Thu, Oct 11, 2012 at 09:06:12PM +0800, Xiao Guangrong wrote: >> On 10/10/2012 11:11 PM, Marcelo Tosatti wrote: >> >>> >>> Why does is_error_pfn() return true for mmio spte? Its not an "error", >>> after all. >>> >>> Please kill is_invalid_pfn and

Re: [PATCH v4 1/5] KVM: MMU: fix release noslot pfn

2012-10-11 Thread Marcelo Tosatti
On Thu, Oct 11, 2012 at 09:06:12PM +0800, Xiao Guangrong wrote: > On 10/10/2012 11:11 PM, Marcelo Tosatti wrote: > > > > > Why does is_error_pfn() return true for mmio spte? Its not an "error", > > after all. > > > > Please kill is_invalid_pfn and use > > > > -> is_error_pfn for checking for e

Re: [PATCH v4 1/5] KVM: MMU: fix release noslot pfn

2012-10-11 Thread Xiao Guangrong
On 10/10/2012 11:11 PM, Marcelo Tosatti wrote: > > Why does is_error_pfn() return true for mmio spte? Its not an "error", > after all. > > Please kill is_invalid_pfn and use > > -> is_error_pfn for checking for errors (mmio spte is not an error pfn, > its a special pfn) > > -> add explicit is

Re: [PATCH v4 1/5] KVM: MMU: fix release noslot pfn

2012-10-10 Thread Marcelo Tosatti
On Sun, Oct 07, 2012 at 08:01:34PM +0800, Xiao Guangrong wrote: > We can not directly call kvm_release_pfn_clean to release the pfn > since we can meet noslot pfn which is used to cache mmio info into > spte > > Signed-off-by: Xiao Guangrong > --- > arch/x86/kvm/mmu.c |3 +-- > virt/kvm/kvm

[PATCH v4 1/5] KVM: MMU: fix release noslot pfn

2012-10-07 Thread Xiao Guangrong
We can not directly call kvm_release_pfn_clean to release the pfn since we can meet noslot pfn which is used to cache mmio info into spte Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c |3 +-- virt/kvm/kvm_main.c |4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --gi