Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 10:18:16AM +0200, Nicolas Ferre wrote: > On 07/05/2020 at 12:03, Nicolas Ferre wrote: > > On 06/05/2020 at 22:18, Jakub Kicinski wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe > > > > > > On Wed, 6 May 2020

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-25 Thread Nicolas Ferre
On 07/05/2020 at 12:03, Nicolas Ferre wrote: On 06/05/2020 at 22:18, Jakub Kicinski wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Use the proper

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-07 Thread Nicolas Ferre
On 06/05/2020 at 22:18, Jakub Kicinski wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Use the proper struct device pointer to check if the wakeup flag

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: > From: Nicolas Ferre > > Use the proper struct device pointer to check if the wakeup flag > and wakeup source are positioned. > Use the one passed by function call which is equivalent to > >dev->dev.parent. > > It's

[PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-06 Thread nicolas.ferre
From: Nicolas Ferre Use the proper struct device pointer to check if the wakeup flag and wakeup source are positioned. Use the one passed by function call which is equivalent to >dev->dev.parent. It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan feature is used.