Re: [PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-12-05 Thread Bjorn Andersson
On Fri 01 Dec 01:10 PST 2017, Jitendra Sharma wrote: > Hi Bjorn, > Hi Jitendra, > On 11/30/2017 6:46 AM, Bjorn Andersson wrote: > > +static int qmi_calc_min_msg_len(struct qmi_elem_info *ei_array, > > + int level) > > +{ > > + int min_msg_len = 0; > min_msg_len shoul

Re: [PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-12-01 Thread Jitendra Sharma
Hi Bjorn, Few minor comments .. On 11/30/2017 6:46 AM, Bjorn Andersson wrote: Add the helper library for encoding and decoding QMI encoded messages. The implementation is taken from lib/qmi_encdec.c of the Qualcomm kernel (msm-3.18). Modifications has been made to the public API, source buffe

Re: [PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-30 Thread Chris Lew
On 11/29/2017 5:16 PM, Bjorn Andersson wrote: Add the helper library for encoding and decoding QMI encoded messages. The implementation is taken from lib/qmi_encdec.c of the Qualcomm kernel (msm-3.18). Modifications has been made to the public API, source buffers has been made const and the de

[PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-29 Thread Bjorn Andersson
Add the helper library for encoding and decoding QMI encoded messages. The implementation is taken from lib/qmi_encdec.c of the Qualcomm kernel (msm-3.18). Modifications has been made to the public API, source buffers has been made const and the debug-logging part was omitted, for now. Tested-By: