Re: [PATCH v4 1/7] blk-mq: avoid setting hctx->tags->cpumask before allocation

2015-09-26 Thread Christoph Hellwig
Looks good. I actually just came up with exactly the same fix after Keith told me to test hotplug for my nvme changes. Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH v4 1/7] blk-mq: avoid setting hctx->tags->cpumask before allocation

2015-09-26 Thread Akinobu Mita
When unmapped hw queue is remapped after CPU topology is changed, hctx->tags->cpumask has to be set after hctx->tags is setup in blk_mq_map_swqueue(), otherwise it causes null pointer dereference. Fixes: f26cdc8536 ("blk-mq: Shared tag enhancements") Signed-off-by: Akinobu Mita Cc: Keith Busch

Re: [PATCH v4 1/7] blk-mq: avoid setting hctx->tags->cpumask before allocation

2015-09-26 Thread Christoph Hellwig
Looks good. I actually just came up with exactly the same fix after Keith told me to test hotplug for my nvme changes. Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

[PATCH v4 1/7] blk-mq: avoid setting hctx->tags->cpumask before allocation

2015-09-26 Thread Akinobu Mita
When unmapped hw queue is remapped after CPU topology is changed, hctx->tags->cpumask has to be set after hctx->tags is setup in blk_mq_map_swqueue(), otherwise it causes null pointer dereference. Fixes: f26cdc8536 ("blk-mq: Shared tag enhancements") Signed-off-by: Akinobu Mita